1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bench: fix buffers/buffer-base64-encode benchmark

Browse Source 
The test is supposed to measure the performance of the base64 encoder
so move the Buffer#write() calls out of the benchmark section.

The overhead of the calls isn't terrible (about 1-3%) but having
unrelated activity in a micro-benchmark is never a good idea.

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
This commit is contained in:
Ben Noordhuis 2014-06-04 15:25:09 +02:00 committed by Trevor Norris
parent 820aaf5b3d
commit 8ae32a9864
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
benchmark/buffers/buffer-base64-encode.js
View File

@ -28,9 +28,8 @@ function main(conf) {
var b = Buffer(N);
var s = '';
for (var i = 0; i < 256; ++i) s += String.fromCharCode(i);
bench.start();
for (var i = 0; i < N; i += 256) b.write(s, i, 256, 'ascii');
bench.start();
for (var i = 0; i < 32; ++i) b.toString('base64');
bench.end(64);
}