1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: simplify removeAllListeners logic

Browse Source 
Unnecessary checks were being performed on if the event existed before
being removed.

_events starts out as null, so reset to null when emptied.

Checking typeof is a lot cheaper than isArray().
This commit is contained in:
Trevor Norris 2013-02-20 15:19:05 -08:00 committed by isaacs
parent dd171d24df
commit 8ab346c98f
1 changed files with 21 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
lib/events.js
View File

@ -245,37 +245,42 @@ EventEmitter.prototype.removeListener = function(type, listener) {
}; };
EventEmitter.prototype.removeAllListeners = function(type) { EventEmitter.prototype.removeAllListeners = function(type) {
if (!this._events) return this; var key, listeners;
// fast path if (arguments.length > 0 && typeof type !== 'string')
throw TypeError('type must not be set or must be a string');
if (!this._events)
return this;
// not listening for removeListener, no need to emit
if (!this._events.removeListener) { if (!this._events.removeListener) {
if (arguments.length === 0) { if (arguments.length === 0)
this._events = {}; this._events = null;
} else if (type && this._events && this._events[type]) { else if (this._events[type])
this._events[type] = null; this._events[type] = null;
}
return this; return this;
} }
// slow(ish) path, emit 'removeListener' events for all removals // emit removeListener for all listeners on all events
if (arguments.length === 0) { if (arguments.length === 0) {
for (var key in this._events) { for (key in this._events) {
if (key === 'removeListener') continue; if (key === 'removeListener') continue;
this.removeAllListeners(key); this.removeAllListeners(key);
} }
this.removeAllListeners('removeListener'); this.removeAllListeners('removeListener');
this._events = {}; this._events = null;
return this; return this;
} }
var listeners = this._events[type]; listeners = this._events[type];
if (isArray(listeners)) {
while (listeners.length) { if (typeof listeners === 'function') {
// LIFO order
this.removeListener(type, listeners[listeners.length - 1]);
}
} else if (listeners) {
this.removeListener(type, listeners); this.removeListener(type, listeners);
} else {
// LIFO order
while (listeners.length)
this.removeListener(type, listeners[listeners.length - 1]);
} }
this._events[type] = null; this._events[type] = null;