1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: move node_trace_writer/buffer.h to agent.cc

Browse Source 
The headers node_trace_writer.h and node_trace_buffer.h are not used in
agent.h but are more of an implementation detail of agent.cc.

This commit suggests moving the inclusion of these headers to agent.cc.

PR-URL: https://github.com/nodejs/node/pull/15598
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Daniel Bevenius 2017-09-23 13:09:07 +01:00
parent 1f21a5cdb7
commit 8a6f376e36
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tracing/agent.cc
View File

@ -2,6 +2,8 @@
#include <sstream> #include <sstream>
#include <string> #include <string>
#include "tracing/node_trace_buffer.h"
#include "tracing/node_trace_writer.h"
#include "env-inl.h" #include "env-inl.h"

5
src/tracing/agent.h
View File

@ -1,15 +1,16 @@
#ifndef SRC_TRACING_AGENT_H_ #ifndef SRC_TRACING_AGENT_H_
#define SRC_TRACING_AGENT_H_ #define SRC_TRACING_AGENT_H_
#include "libplatform/v8-tracing.h"
#include "node_platform.h" #include "node_platform.h"
#include "tracing/node_trace_buffer.h"
#include "tracing/node_trace_writer.h"
#include "uv.h" #include "uv.h"
#include "v8.h" #include "v8.h"
namespace node { namespace node {
namespace tracing { namespace tracing {
using v8::platform::tracing::TracingController;
class Agent { class Agent {
public: public:
Agent(); Agent();