1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: run test-setproctitle where supported

Browse Source 
Setting the process title has been enabled in libuv on AIX and z/OS. The
latest level of libuv skips only skips testing of uv_set_process_title
when __sun is #defined.

This change simplifies the skip test so the test is only skipped when
common.isSunOS is true to match libuv. Skip running the `ps` part of the
test on Windows.

PR-URL: https://github.com/nodejs/node/pull/11416
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Howard Hellyer 2017-02-14 14:14:05 +00:00 committed by Gibson Fahnestock
parent ed3ecd0d4e
commit 893632ec07
No known key found for this signature in database
GPG Key ID: B01FBB92821C587A
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-setproctitle.js
View File

@ -3,7 +3,7 @@
const common = require('../common'); const common = require('../common');
// FIXME add sunos support // FIXME add sunos support
if (!(common.isFreeBSD || common.isOSX || common.isLinux)) { if (common.isSunOS) {
console.log(`1..0 # Skipped: Unsupported platform [${process.platform}]`); console.log(`1..0 # Skipped: Unsupported platform [${process.platform}]`);
return; return;
} }
@ -21,6 +21,10 @@ assert.notStrictEqual(process.title, title);
process.title = title; process.title = title;
assert.strictEqual(process.title, title); assert.strictEqual(process.title, title);
// Test setting the title but do not try to run `ps` on Windows.
if (common.isWindows)
return;
exec(`ps -p ${process.pid} -o args=`, function callback(error, stdout, stderr) { exec(`ps -p ${process.pid} -o args=`, function callback(error, stdout, stderr) {
assert.ifError(error); assert.ifError(error);
assert.strictEqual(stderr, ''); assert.strictEqual(stderr, '');