tests: fix more lint issues

This commit is contained in:
Bert Belder 2012-01-17 20:16:49 +01:00
parent 4865063924
commit 892056bf97
8 changed files with 87 additions and 69 deletions

View File

@ -28,11 +28,16 @@ var assert = require('assert'),
// We're trying to reproduce:
// $ echo "hello\nnode\nand\nworld" | grep o | sed s/o/a/
var echo = is_windows ? spawn('cmd.exe', ['/c', 'echo', 'hello&&', 'echo',
'node&&', 'echo', 'and&&', 'echo', 'world']) :
spawn('echo', ['hello\nnode\nand\nworld\n']),
grep = spawn('grep', ['o']),
sed = spawn('sed', ['s/o/O/']);
var grep = spawn('grep', ['o']),
sed = spawn('sed', ['s/o/O/']),
echo;
if (is_windows) {
echo = spawn('cmd.exe', ['/c', 'echo', 'hello&&', 'echo',
'node&&', 'echo', 'and&&', 'echo', 'world']);
} else {
echo = spawn('echo', ['hello\nnode\nand\nworld\n']);
}
/*
* grep and sed hang if the spawn function leaks file descriptors to child

View File

@ -112,7 +112,8 @@ function test(handler, request_generator, response_validator) {
function request_generator() {
return ('GET / HTTP/1.0\r\n' +
'User-Agent: curl/7.19.7 (x86_64-pc-linux-gnu) libcurl/7.19.7 OpenSSL/0.9.8k zlib/1.2.3.3 libidn/1.15\r\n' +
'User-Agent: curl/7.19.7 (x86_64-pc-linux-gnu) libcurl/7.19.7 ' +
'OpenSSL/0.9.8k zlib/1.2.3.3 libidn/1.15\r\n' +
'Host: 127.0.0.1:1337\r\n' +
'Accept: */*\r\n' +
'\r\n');
@ -147,7 +148,8 @@ function test(handler, request_generator, response_validator) {
function request_generator() {
return ('GET / HTTP/1.1\r\n' +
'User-Agent: curl/7.19.7 (x86_64-pc-linux-gnu) libcurl/7.19.7 OpenSSL/0.9.8k zlib/1.2.3.3 libidn/1.15\r\n' +
'User-Agent: curl/7.19.7 (x86_64-pc-linux-gnu) libcurl/7.19.7 ' +
'OpenSSL/0.9.8k zlib/1.2.3.3 libidn/1.15\r\n' +
'Connection: close\r\n' +
'Host: 127.0.0.1:1337\r\n' +
'Accept: */*\r\n' +

View File

@ -26,7 +26,6 @@ if (process.platform === 'win32') {
var file = path.join(common.fixturesDir, 'a.js');
var resolvedFile = path.resolve(file);
var networkFile = '\\\\someserver\\someshare\\somefile';
assert.equal('\\\\?\\' + resolvedFile, path._makeLong(file));
assert.equal('\\\\?\\' + resolvedFile, path._makeLong('\\\\?\\' + file));
@ -34,5 +33,6 @@ if (process.platform === 'win32') {
path._makeLong('\\\\someserver\\someshare\\somefile'));
assert.equal('\\\\?\\UNC\\someserver\\someshare\\somefile',
path._makeLong('\\\\?\\UNC\\someserver\\someshare\\somefile'));
assert.equal('\\\\.\\pipe\\somepipe', path._makeLong('\\\\.\\pipe\\somepipe'));
assert.equal('\\\\.\\pipe\\somepipe',
path._makeLong('\\\\.\\pipe\\somepipe'));
}

View File

@ -49,7 +49,8 @@ var testMe = repl.start('', putIn);
putIn.run(['.clear']);
putIn.run([
'var inner = {',
'one:1']);
'one:1'
]);
testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, doesNotBreak);
});
@ -66,7 +67,8 @@ putIn.run(['.clear']);
putIn.run([
'var inner = ( true ' ,
'?',
'{one: 1} : ']);
'{one: 1} : '
]);
testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, doesNotBreak);
});
@ -76,7 +78,8 @@ putIn.run(['.clear']);
// Tab Complete will return a simple local variable
putIn.run([
'var top = function () {',
'var inner = {one:1};']);
'var inner = {one:1};'
]);
testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, works);
});
@ -95,7 +98,8 @@ putIn.run([
'var top = function () {',
'var inner = {',
' one:1',
'};']);
'};'
]);
testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, works);
});
@ -108,7 +112,8 @@ putIn.run([
'var top = function (one, two) {',
'var inner = {',
' one:1',
'};']);
'};'
]);
testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, works);
});
@ -122,7 +127,8 @@ putIn.run([
'(function test () {',
'var inner = {',
' one:1',
'};']);
'};'
]);
testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, works);
});
@ -137,7 +143,8 @@ putIn.run([
' one, two) {',
'var inner = {',
' one:1',
'};']);
'};'
]);
testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, doesNotBreak);
});
@ -151,7 +158,8 @@ putIn.run([
'{',
'var inner = {',
' one:1',
'};']);
'};'
]);
testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, doesNotBreak);
});
@ -166,7 +174,8 @@ putIn.run([
'{',
'var inner = {',
' one:1',
'};']);
'};'
]);
testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, doesNotBreak);
});

View File

@ -54,9 +54,11 @@ try {
}
catch (e) {
gh1140Exception = e;
assert.ok(/expected-filename/.test(e.stack), 'expected appearance of filename in Error stack');
assert.ok(/expected-filename/.test(e.stack),
'expected appearance of filename in Error stack');
}
assert.ok(gh1140Exception, 'expected exception from runInContext signature test');
assert.ok(gh1140Exception,
'expected exception from runInContext signature test');
// GH-558, non-context argument segfaults / raises assertion
function isTypeError(o) {