From 89164a096d73da71562e09a18c5ce2b997f28513 Mon Sep 17 00:00:00 2001 From: Matt Loring Date: Tue, 26 Apr 2016 17:29:05 -0700 Subject: [PATCH] benchmark: Fix crash in net benchmarks Net benchmarks create partial event emitters that do not have all of the required event emitter functions. They currently mock out `on`, `once`, and `emit` functions. This change mocks out `prependListener` as well to avoid crashing in `_stream_readable`. PR-URL: https://www.github.com/nodejs/node/pull/6407 Fixes: https://www.github.com/nodejs/node/issues/6405 Reviewed-By: Anna Henningsen Reviewed-By: Minwoo Jung Reviewed-By: Matthew Loring Reviewed-By: James M Snell --- benchmark/net/net-c2s-cork.js | 1 + benchmark/net/net-c2s.js | 1 + benchmark/net/net-pipe.js | 1 + benchmark/net/net-s2c.js | 1 + 4 files changed, 4 insertions(+) diff --git a/benchmark/net/net-c2s-cork.js b/benchmark/net/net-c2s-cork.js index 60b4542a47b..5e8dd349d68 100644 --- a/benchmark/net/net-c2s-cork.js +++ b/benchmark/net/net-c2s-cork.js @@ -62,6 +62,7 @@ Writer.prototype.write = function(chunk, encoding, cb) { Writer.prototype.on = function() {}; Writer.prototype.once = function() {}; Writer.prototype.emit = function() {}; +Writer.prototype.prependListener = function() {}; function server() { var writer = new Writer(); diff --git a/benchmark/net/net-c2s.js b/benchmark/net/net-c2s.js index d64a5517e8f..2c3bbe3c6a1 100644 --- a/benchmark/net/net-c2s.js +++ b/benchmark/net/net-c2s.js @@ -62,6 +62,7 @@ Writer.prototype.write = function(chunk, encoding, cb) { Writer.prototype.on = function() {}; Writer.prototype.once = function() {}; Writer.prototype.emit = function() {}; +Writer.prototype.prependListener = function() {}; function Reader() { diff --git a/benchmark/net/net-pipe.js b/benchmark/net/net-pipe.js index b6e95a8b75d..fd3a6d4f433 100644 --- a/benchmark/net/net-pipe.js +++ b/benchmark/net/net-pipe.js @@ -62,6 +62,7 @@ Writer.prototype.write = function(chunk, encoding, cb) { Writer.prototype.on = function() {}; Writer.prototype.once = function() {}; Writer.prototype.emit = function() {}; +Writer.prototype.prependListener = function() {}; function Reader() { diff --git a/benchmark/net/net-s2c.js b/benchmark/net/net-s2c.js index 2ef151f4ca4..fc3f3e13894 100644 --- a/benchmark/net/net-s2c.js +++ b/benchmark/net/net-s2c.js @@ -62,6 +62,7 @@ Writer.prototype.write = function(chunk, encoding, cb) { Writer.prototype.on = function() {}; Writer.prototype.once = function() {}; Writer.prototype.emit = function() {}; +Writer.prototype.prependListener = function() {}; function Reader() {