1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-vm-debug-context

Browse Source 
change var to const or let
change assert.equal to assert.strictEqual

PR-URL: https://github.com/nodejs/node/pull/9875
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
makenova 2016-12-01 09:36:20 -06:00 committed by Michaël Zasso
parent 947baaf5b7
commit 8892433792
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
test/parallel/test-vm-debug-context.js
View File

@ -1,9 +1,9 @@
/* eslint-disable no-debugger */ /* eslint-disable no-debugger */
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var vm = require('vm'); const vm = require('vm');
var spawn = require('child_process').spawn; const spawn = require('child_process').spawn;
assert.throws(function() { assert.throws(function() {
vm.runInDebugContext('*'); vm.runInDebugContext('*');
@ -21,8 +21,8 @@ assert.throws(function() {
vm.runInDebugContext('(function(f) { f(f) })(function(f) { f(f) })'); vm.runInDebugContext('(function(f) { f(f) })(function(f) { f(f) })');
}, /RangeError/); }, /RangeError/);
assert.equal(typeof vm.runInDebugContext('this'), 'object'); assert.strictEqual(typeof vm.runInDebugContext('this'), 'object');
assert.equal(typeof vm.runInDebugContext('Debug'), 'object'); assert.strictEqual(typeof vm.runInDebugContext('Debug'), 'object');
assert.strictEqual(vm.runInDebugContext(), undefined); assert.strictEqual(vm.runInDebugContext(), undefined);
assert.strictEqual(vm.runInDebugContext(0), 0); assert.strictEqual(vm.runInDebugContext(0), 0);
@ -46,11 +46,11 @@ assert.strictEqual(vm.runInDebugContext(undefined), undefined);
debugger; debugger;
} }
assert.equal(breaks, 0); assert.strictEqual(breaks, 0);
Debug.setListener(ondebugevent); Debug.setListener(ondebugevent);
assert.equal(breaks, 0); assert.strictEqual(breaks, 0);
breakpoint(); breakpoint();
assert.equal(breaks, 1); assert.strictEqual(breaks, 1);
} }
// Can set listeners and breakpoints on a single line file // Can set listeners and breakpoints on a single line file
@ -73,24 +73,24 @@ assert.strictEqual(vm.runInDebugContext(undefined), undefined);
// See https://github.com/nodejs/node/issues/1190, fatal errors should not // See https://github.com/nodejs/node/issues/1190, fatal errors should not
// crash the process. // crash the process.
var script = common.fixturesDir + '/vm-run-in-debug-context.js'; const script = common.fixturesDir + '/vm-run-in-debug-context.js';
var proc = spawn(process.execPath, [script]); let proc = spawn(process.execPath, [script]);
var data = []; const data = [];
proc.stdout.on('data', common.fail); proc.stdout.on('data', common.fail);
proc.stderr.on('data', data.push.bind(data)); proc.stderr.on('data', data.push.bind(data));
proc.stderr.once('end', common.mustCall(function() { proc.stderr.once('end', common.mustCall(function() {
var haystack = Buffer.concat(data).toString('utf8'); const haystack = Buffer.concat(data).toString('utf8');
assert(/SyntaxError: Unexpected token \*/.test(haystack)); assert(/SyntaxError: Unexpected token \*/.test(haystack));
})); }));
proc.once('exit', common.mustCall(function(exitCode, signalCode) { proc.once('exit', common.mustCall(function(exitCode, signalCode) {
assert.equal(exitCode, 1); assert.strictEqual(exitCode, 1);
assert.equal(signalCode, null); assert.strictEqual(signalCode, null);
})); }));
proc = spawn(process.execPath, [script, 'handle-fatal-exception']); proc = spawn(process.execPath, [script, 'handle-fatal-exception']);
proc.stdout.on('data', common.fail); proc.stdout.on('data', common.fail);
proc.stderr.on('data', common.fail); proc.stderr.on('data', common.fail);
proc.once('exit', common.mustCall(function(exitCode, signalCode) { proc.once('exit', common.mustCall(function(exitCode, signalCode) {
assert.equal(exitCode, 42); assert.strictEqual(exitCode, 42);
assert.equal(signalCode, null); assert.strictEqual(signalCode, null);
})); }));