1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor the code in test-util-debug.js

Browse Source 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions
* removed unwanted console log

PR-URL: https://github.com/nodejs/node/pull/10531
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This commit is contained in:
sivaprasanna 2016-12-30 11:01:03 +05:30 committed by James M Snell
parent c1b12a2896
commit 8839d504cc
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
test/sequential/test-util-debug.js
View File

@ -17,44 +17,43 @@ function parent() {
}
function test(environ, shouldWrite) {
var expectErr = '';
let expectErr = '';
if (shouldWrite) {
expectErr = 'TUD %PID%: this { is: \'a\' } /debugging/\n' +
'TUD %PID%: number=1234 string=asdf obj={"foo":"bar"}\n';
}
var expectOut = 'ok\n';
const expectOut = 'ok\n';
const spawn = require('child_process').spawn;
var child = spawn(process.execPath, [__filename, 'child'], {
const child = spawn(process.execPath, [__filename, 'child'], {
env: Object.assign(process.env, { NODE_DEBUG: environ })
});
expectErr = expectErr.split('%PID%').join(child.pid);
var err = '';
let err = '';
child.stderr.setEncoding('utf8');
child.stderr.on('data', function(c) {
child.stderr.on('data', (c) => {
err += c;
});
var out = '';
let out = '';
child.stdout.setEncoding('utf8');
child.stdout.on('data', function(c) {
child.stdout.on('data', (c) => {
out += c;
});
child.on('close', common.mustCall(function(c) {
child.on('close', common.mustCall((c) => {
assert(!c);
assert.equal(err, expectErr);
assert.equal(out, expectOut);
console.log('ok %j %j', environ, shouldWrite);
assert.strictEqual(err, expectErr);
assert.strictEqual(out, expectOut);
}));
}
function child() {
const util = require('util');
var debug = util.debuglog('tud');
const debug = util.debuglog('tud');
debug('this', { is: 'a' }, /debugging/);
debug('number=%d string=%s obj=%j', 1234, 'asdf', { foo: 'bar' });
console.log('ok');