From 88333f7ace007dc0ef57803b954c55976f523ffa Mon Sep 17 00:00:00 2001 From: Trevor Norris Date: Wed, 15 May 2013 14:58:14 -0700 Subject: [PATCH] http: don't slice unless necessary The incoming Buffer was being sliced just to possibly not be used. Instead place the .slice inside the conditional to not be created unless necessary. --- lib/_http_server.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/_http_server.js b/lib/_http_server.js index 945baf3226e..bbbcb371d41 100644 --- a/lib/_http_server.js +++ b/lib/_http_server.js @@ -352,11 +352,10 @@ function connectionListener(socket) { parser.finish(); freeParser(parser, req); - // This is start + byteParsed - var bodyHead = d.slice(start + bytesParsed, end); - var eventName = req.method === 'CONNECT' ? 'connect' : 'upgrade'; if (EventEmitter.listenerCount(self, eventName) > 0) { + // This is start + byteParsed + var bodyHead = d.slice(start + bytesParsed, end); self.emit(eventName, req, req.socket, bodyHead); } else { // Got upgrade header or CONNECT method, but have no handler.