1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

stream: always defer readable in EOF when sync

Browse Source 
Fix a regression introduced by
https://github.com/nodejs/node/pull/18515 that broke
the dicer module tests.

See: https://github.com/nodejs/node/pull/18515

PR-URL: https://github.com/nodejs/node/pull/18615
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit is contained in:
Matteo Collina 2018-02-07 10:52:04 +01:00
parent d8f73385e2
commit 87b9bceacb
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/_stream_readable.js
View File

@ -488,9 +488,9 @@ function onEofChunk(stream, state) {
} }
state.ended = true; state.ended = true;
if (state.sync && state.length) { if (state.sync) {
// if we are sync and have data in the buffer, wait until next tick // if we are sync, wait until next tick to emit the data.
// to emit the data. otherwise we risk emitting data in the flow() // Otherwise we risk emitting data in the flow()
// the readable code triggers during a read() call // the readable code triggers during a read() call
emitReadable(stream); emitReadable(stream);
} else { } else {

2
test/parallel/test-stream-readable-object-multi-push-async.js
View File

@ -160,7 +160,7 @@ const BATCH = 10;
}); });
readable.on('end', common.mustCall(() => { readable.on('end', common.mustCall(() => {
assert.strictEqual(nextTickPassed, false); assert.strictEqual(nextTickPassed, true);
})); }));
} }