console: mark special console properties as non-enumerable

This makes sure internal console properties are not visible during
default inspection. They are still visible when inspecting the
console with `showHidden` set to `true`.

These properties are confusing while working with the REPL and easily
show up.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: https://github.com/nodejs/node/pull/33524
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

lib/internal/console/constructor.js

@@ -155,17 +155,25 @@ ObjectDefineProperty(Console, SymbolHasInstance, {
   }
 });
 
-// Eager version for the Console constructor
-Console.prototype[kBindStreamsEager] = function(stdout, stderr) {
+const kColorInspectOptions = { colors: true };
+const kNoColorInspectOptions = {};
+
+ObjectDefineProperties(Console.prototype, {
+  [kBindStreamsEager]: {
+    ...consolePropAttributes,
+    // Eager version for the Console constructor
+    value: function(stdout, stderr) {
       ObjectDefineProperties(this, {
         '_stdout': { ...consolePropAttributes, value: stdout },
         '_stderr': { ...consolePropAttributes, value: stderr }
       });
-};
-
-// Lazily load the stdout and stderr from an object so we don't
-// create the stdio streams when they are not even accessed
-Console.prototype[kBindStreamsLazy] = function(object) {
+    }
+  },
+  [kBindStreamsLazy]: {
+    ...consolePropAttributes,
+    // Lazily load the stdout and stderr from an object so we don't
+    // create the stdio streams when they are not even accessed
+    value: function(object) {
       let stdout;
       let stderr;
       ObjectDefineProperties(this, {
@@ -188,10 +196,11 @@ Console.prototype[kBindStreamsLazy] = function(object) {
           set(value) { stderr = value; }
         }
       });
-};
-
-Console.prototype[kBindProperties] = function(ignoreErrors, colorMode,
-                                              groupIndentation = 2) {
+    }
+  },
+  [kBindProperties]: {
+    ...consolePropAttributes,
+    value: function(ignoreErrors, colorMode, groupIndentation = 2) {
       ObjectDefineProperties(this, {
         '_stdoutErrorHandler': {
           ...consolePropAttributes,
@@ -216,30 +225,11 @@ Console.prototype[kBindProperties] = function(ignoreErrors, colorMode,
           value: groupIndentation
         },
       });
-};
-
-// Make a function that can serve as the callback passed to `stream.write()`.
-function createWriteErrorHandler(instance, streamSymbol) {
-  return (err) => {
-    // This conditional evaluates to true if and only if there was an error
-    // that was not already emitted (which happens when the _write callback
-    // is invoked asynchronously).
-    const stream = streamSymbol === kUseStdout ?
-      instance._stdout : instance._stderr;
-    if (err !== null && !stream._writableState.errorEmitted) {
-      // If there was an error, it will be emitted on `stream` as
-      // an `error` event. Adding a `once` listener will keep that error
-      // from becoming an uncaught exception, but since the handler is
-      // removed after the event, non-console.* writes won't be affected.
-      // we are only adding noop if there is no one else listening for 'error'
-      if (stream.listenerCount('error') === 0) {
-        stream.once('error', noop);
     }
-    }
-  };
-}
-
-Console.prototype[kWriteToConsole] = function(streamSymbol, string) {
+  },
+  [kWriteToConsole]: {
+    ...consolePropAttributes,
+    value: function(streamSymbol, string) {
       const ignoreErrors = this._ignoreErrors;
       const groupIndent = this[kGroupIndent];
 
@@ -262,25 +252,26 @@ Console.prototype[kWriteToConsole] = function(streamSymbol, string) {
       // on POSIX systems) or asynchronously (e.g. pipes on POSIX systems), so
       // handle both situations.
       try {
-    // Add and later remove a noop error handler to catch synchronous errors.
+        // Add and later remove a noop error handler to catch synchronous
+        // errors.
         if (stream.listenerCount('error') === 0)
           stream.once('error', noop);
 
         stream.write(string, errorHandler);
       } catch (e) {
-    // Console is a debugging utility, so it swallowing errors is not desirable
-    // even in edge cases such as low stack space.
+        // Console is a debugging utility, so it swallowing errors is not
+        // desirable even in edge cases such as low stack space.
         if (isStackOverflowError(e))
           throw e;
         // Sorry, there's no proper way to pass along the error here.
       } finally {
         stream.removeListener('error', noop);
       }
-};
-
-const kColorInspectOptions = { colors: true };
-const kNoColorInspectOptions = {};
-Console.prototype[kGetInspectOptions] = function(stream) {
+    }
+  },
+  [kGetInspectOptions]: {
+    ...consolePropAttributes,
+    value: function(stream) {
       let color = this[kColorMode];
       if (color === 'auto') {
         color = stream.isTTY && (
@@ -297,17 +288,44 @@ Console.prototype[kGetInspectOptions] = function(stream) {
       }
 
       return color ? kColorInspectOptions : kNoColorInspectOptions;
-};
-
-Console.prototype[kFormatForStdout] = function(args) {
+    }
+  },
+  [kFormatForStdout]: {
+    ...consolePropAttributes,
+    value: function(args) {
       const opts = this[kGetInspectOptions](this._stdout);
       return formatWithOptions(opts, ...args);
-};
-
-Console.prototype[kFormatForStderr] = function(args) {
+    }
+  },
+  [kFormatForStderr]: {
+    ...consolePropAttributes,
+    value: function(args) {
       const opts = this[kGetInspectOptions](this._stderr);
       return formatWithOptions(opts, ...args);
-};
+    }
+  },
+});
+
+// Make a function that can serve as the callback passed to `stream.write()`.
+function createWriteErrorHandler(instance, streamSymbol) {
+  return (err) => {
+    // This conditional evaluates to true if and only if there was an error
+    // that was not already emitted (which happens when the _write callback
+    // is invoked asynchronously).
+    const stream = streamSymbol === kUseStdout ?
+      instance._stdout : instance._stderr;
+    if (err !== null && !stream._writableState.errorEmitted) {
+      // If there was an error, it will be emitted on `stream` as
+      // an `error` event. Adding a `once` listener will keep that error
+      // from becoming an uncaught exception, but since the handler is
+      // removed after the event, non-console.* writes won't be affected.
+      // we are only adding noop if there is no one else listening for 'error'
+      if (stream.listenerCount('error') === 0) {
+        stream.once('error', noop);
+      }
+    }
+  };
+}
 
 const consoleMethods = {
   log(...args) {