1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: fix assert fail from JS API

Browse Source 
Length arguments passed to SlowBuffer were coerced to Int32, not Uint32,
so passing a negative number would throw the following:

node: ../src/smalloc.cc:244: void node::smalloc::Alloc(): Assertion `length <= kMaxLength' failed.
Aborted (core dumped)

That has been fixed by coercing to Uint32 and comparing the value
against kMaxLength.
This commit is contained in:
Trevor Norris 2013-08-26 03:26:31 -07:00
parent 16a60ed2a3
commit 873b5f8428
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/buffer.js
View File

@ -89,7 +89,9 @@ function Buffer(subject, encoding) {
function SlowBuffer(length) {
length = ~~length;
length = length >>> 0;
if (length > kMaxLength)
throw new RangeError('length > kMaxLength');
var b = new NativeBuffer(length);
alloc(b, length);
return b;