1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tls: include invalid method name in thrown error

Browse Source 
When an invalid TLS method name error is thrown, include the invalid
name in the error message.

PR-URL: https://github.com/nodejs/node/pull/27390
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Sam Roberts 2019-04-24 10:44:01 -07:00
parent 1d022e8253
commit 86b4f3729a
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/node_crypto.cc
View File

@ -627,7 +627,8 @@ void SecureContext::Init(const FunctionCallbackInfo<Value>& args) {
max_version = TLS1_2_VERSION; max_version = TLS1_2_VERSION;
method = TLS_client_method(); method = TLS_client_method();
} else { } else {
THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, "Unknown method"); const std::string msg("Unknown method: ");
THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, (msg + * sslmethod).c_str());
return; return;
} }
} }

5
test/parallel/test-tls-no-sslv23.js
View File

@ -8,7 +8,10 @@ const tls = require('tls');
assert.throws(function() { assert.throws(function() {
tls.createSecureContext({ secureProtocol: 'blargh' }); tls.createSecureContext({ secureProtocol: 'blargh' });
}, /Unknown method/); }, {
code: 'ERR_TLS_INVALID_PROTOCOL_METHOD',
message: 'Unknown method: blargh',
});
const errMessageSSLv2 = /SSLv2 methods disabled/; const errMessageSSLv2 = /SSLv2 methods disabled/;