1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http2: eliminate dead code

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This commit is contained in:
James M Snell 2017-09-29 15:06:45 -07:00
parent 8f4db313f0
commit 8691d8bc85
3 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/node_http2.cc
View File

@ -25,9 +25,6 @@ Freelist<Nghttp2Stream, FREELIST_MAX> stream_free_list;
Freelist<nghttp2_header_list, FREELIST_MAX> header_free_list;
Freelist<nghttp2_data_chunks_t, FREELIST_MAX>
data_chunks_free_list;
Nghttp2Session::Callbacks Nghttp2Session::callback_struct_saved[2] = {
Callbacks(false),
Callbacks(true)};

9
src/node_http2_core-inl.h
View File

@ -30,9 +30,6 @@ extern Freelist<Nghttp2Stream, FREELIST_MAX> stream_free_list;
extern Freelist<nghttp2_header_list, FREELIST_MAX> header_free_list;
extern Freelist<nghttp2_data_chunks_t, FREELIST_MAX>
data_chunks_free_list;
#ifdef NODE_DEBUG_HTTP2
inline int Nghttp2Session::OnNghttpError(nghttp2_session* session,
const char* message,
@ -905,12 +902,6 @@ inline void Nghttp2Stream::ReadStop() {
id_, 0);
}
nghttp2_data_chunks_t::~nghttp2_data_chunks_t() {
for (unsigned int n = 0; n < nbufs; n++) {
free(buf[n].base);
}
}
Nghttp2Session::Callbacks::Callbacks(bool kHasGetPaddingCallback) {
nghttp2_session_callbacks_new(&callbacks);
nghttp2_session_callbacks_set_on_begin_headers_callback(

8
src/node_http2_core.h
View File

@ -40,7 +40,6 @@ class Nghttp2Stream;
struct nghttp2_stream_write_t;
struct nghttp2_data_chunk_t;
struct nghttp2_data_chunks_t;
#define MAX_BUFFER_COUNT 10
#define SEND_BUFFER_RECOMMENDED_SIZE 4096
@ -508,13 +507,6 @@ struct nghttp2_data_chunk_t {
nghttp2_data_chunk_t* next = nullptr;
};
struct nghttp2_data_chunks_t {
unsigned int nbufs = 0;
uv_buf_t buf[MAX_BUFFER_COUNT];
inline ~nghttp2_data_chunks_t();
};
} // namespace http2
} // namespace node