1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: remove unused parameters

Browse Source 
Functions completeConfig, completeRun, and
updateProgress had unused parameters. These
were removed.

PR-URL: https://github.com/nodejs/node/pull/14526
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Matthew Alsup 2017-07-27 19:52:39 -05:00 committed by Rich Trott
parent b8e0a5ea23
commit 859ccd78b5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
benchmark/_benchmark_progress.js
View File

@ -65,12 +65,12 @@ class BenchmarkProgress {
this.updateProgress(); this.updateProgress();
} }
completeConfig(data) { completeConfig() {
this.completedConfig++; this.completedConfig++;
this.updateProgress(); this.updateProgress();
} }
completeRun(job) { completeRun() {
this.completedRuns++; this.completedRuns++;
this.updateProgress(); this.updateProgress();
} }
@ -108,7 +108,7 @@ class BenchmarkProgress {
`${caption} `; `${caption} `;
} }
updateProgress(finished) { updateProgress() {
if (!process.stderr.isTTY || process.stdout.isTTY) { if (!process.stderr.isTTY || process.stdout.isTTY) {
return; return;
} }