From 85496e94d3b7053f0954b15973c55bb1e8e1f11b Mon Sep 17 00:00:00 2001
From: kball <kball@zendev.com>
Date: Fri, 21 Jun 2019 15:08:38 -0500
Subject: [PATCH] lib: fix stack overflow check to not break on primitives

PR-URL: https://github.com/nodejs/node/pull/28338
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
---
 lib/internal/errors.js                            |  2 +-
 test/parallel/test-console-log-throw-primitive.js | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100644 test/parallel/test-console-log-throw-primitive.js

diff --git a/lib/internal/errors.js b/lib/internal/errors.js
index ff1449f519a..873523f64d3 100644
--- a/lib/internal/errors.js
+++ b/lib/internal/errors.js
@@ -587,7 +587,7 @@ function isStackOverflowError(err) {
     }
   }
 
-  return err.name === maxStack_ErrorName &&
+  return err && err.name === maxStack_ErrorName &&
          err.message === maxStack_ErrorMessage;
 }
 
diff --git a/test/parallel/test-console-log-throw-primitive.js b/test/parallel/test-console-log-throw-primitive.js
new file mode 100644
index 00000000000..a1a9ca25726
--- /dev/null
+++ b/test/parallel/test-console-log-throw-primitive.js
@@ -0,0 +1,14 @@
+'use strict';
+require('../common');
+const { Writable } = require('stream');
+const { Console } = require('console');
+
+const stream = new Writable({
+  write() {
+    throw null; // eslint-disable-line no-throw-literal
+  }
+});
+
+const console = new Console({ stdout: stream });
+
+console.log('test'); // Should not throw