1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Move HandleWrap rules to one place

Browse Source
This commit is contained in:
Ryan Dahl 2011-07-18 13:45:11 -07:00
parent e5cceffe6a
commit 85404c5c55
4 changed files with 20 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/handle_wrap.h
View File

@ -3,6 +3,26 @@
namespace node {
// Rules:
//
// - Do not throw from handle methods. Set errno.
//
// - MakeCallback may only be made directly off the event loop.
// That is there can be no JavaScript stack frames underneith it.
// (Is there anyway to assert that?)
//
// - No use of v8::WeakReferenceCallback. The close callback signifies that
// we're done with a handle - external resources can be freed.
//
// - Reusable?
//
// - The uv_close_cb is used to free the c++ object. The close callback
// is not made into javascript land.
//
// - uv_ref, uv_unref counts are managed at this layer to avoid needless
// js/c++ boundary crossing. At the javascript layer that should all be
// taken care of.
class HandleWrap {
public:
static void Initialize(v8::Handle<v8::Object> target);

21
src/pipe_wrap.cc
View File

@ -4,27 +4,6 @@
#include <handle_wrap.h>
#include <stream_wrap.h>
// Rules:
//
// - Do not throw from handle methods. Set errno.
//
// - MakeCallback may only be made directly off the event loop.
// That is there can be no JavaScript stack frames underneith it.
// (Is there anyway to assert that?)
//
// - No use of v8::WeakReferenceCallback. The close callback signifies that
// we're done with a handle - external resources can be freed.
//
// - Reusable?
//
// - The uv_close_cb is used to free the c++ object. The close callback
// is not made into javascript land.
//
// - uv_ref, uv_unref counts are managed at this layer to avoid needless
// js/c++ boundary crossing. At the javascript layer that should all be
// taken care of.
#define UNWRAP \
assert(!args.Holder().IsEmpty()); \
assert(args.Holder()->InternalFieldCount() > 0); \

21
src/tcp_wrap.cc
View File

@ -19,27 +19,6 @@
# define uv_inet_ntop inet_ntop
#endif
// Rules:
//
// - Do not throw from handle methods. Set errno.
//
// - MakeCallback may only be made directly off the event loop.
// That is there can be no JavaScript stack frames underneith it.
// (Is there anyway to assert that?)
//
// - No use of v8::WeakReferenceCallback. The close callback signifies that
// we're done with a handle - external resources can be freed.
//
// - Reusable?
//
// - The uv_close_cb is used to free the c++ object. The close callback
// is not made into javascript land.
//
// - uv_ref, uv_unref counts are managed at this layer to avoid needless
// js/c++ boundary crossing. At the javascript layer that should all be
// taken care of.
#define UNWRAP \
assert(!args.Holder().IsEmpty()); \
assert(args.Holder()->InternalFieldCount() > 0); \

21
src/timer_wrap.cc
View File

@ -1,27 +1,6 @@
#include <node.h>
#include <handle_wrap.h>
// Rules:
//
// - Do not throw from handle methods. Set errno.
//
// - MakeCallback may only be made directly off the event loop.
// That is there can be no JavaScript stack frames underneith it.
// (Is there anyway to assert that?)
//
// - No use of v8::WeakReferenceCallback. The close callback signifies that
// we're done with a handle - external resources can be freed.
//
// - Reusable?
//
// - The uv_close_cb is used to free the c++ object. The close callback
// is not made into javascript land.
//
// - uv_ref, uv_unref counts are managed at this layer to avoid needless
// js/c++ boundary crossing. At the javascript layer that should all be
// taken care of.
#define UNWRAP \
assert(!args.Holder().IsEmpty()); \
assert(args.Holder()->InternalFieldCount() > 0); \