src: apply clang-tidy rule performance-unnecessary-value-param

PR-URL: https://github.com/nodejs/node/pull/26042
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
gengjiawen 2019-02-11 17:20:52 +08:00 committed by Daniel Bevenius
parent b200a46bef
commit 8375c706ad
10 changed files with 25 additions and 19 deletions

View File

@ -37,6 +37,8 @@
#include <stddef.h> #include <stddef.h>
#include <stdint.h> #include <stdint.h>
#include <utility>
namespace node { namespace node {
inline v8::Isolate* IsolateData::isolate() const { inline v8::Isolate* IsolateData::isolate() const {
@ -395,7 +397,7 @@ inline uv_loop_t* Environment::event_loop() const {
inline void Environment::TryLoadAddon( inline void Environment::TryLoadAddon(
const char* filename, const char* filename,
int flags, int flags,
std::function<bool(binding::DLib*)> was_loaded) { const std::function<bool(binding::DLib*)>& was_loaded) {
loaded_addons_.emplace_back(filename, flags); loaded_addons_.emplace_back(filename, flags);
if (!was_loaded(&loaded_addons_.back())) { if (!was_loaded(&loaded_addons_.back())) {
loaded_addons_.pop_back(); loaded_addons_.pop_back();
@ -597,7 +599,7 @@ inline std::shared_ptr<PerIsolateOptions> IsolateData::options() {
inline void IsolateData::set_options( inline void IsolateData::set_options(
std::shared_ptr<PerIsolateOptions> options) { std::shared_ptr<PerIsolateOptions> options) {
options_ = options; options_ = std::move(options);
} }
void Environment::CreateImmediate(native_immediate_callback cb, void Environment::CreateImmediate(native_immediate_callback cb,

View File

@ -663,9 +663,10 @@ class Environment {
inline v8::Isolate* isolate() const; inline v8::Isolate* isolate() const;
inline uv_loop_t* event_loop() const; inline uv_loop_t* event_loop() const;
inline void TryLoadAddon(const char* filename, inline void TryLoadAddon(
int flags, const char* filename,
std::function<bool(binding::DLib*)> was_loaded); int flags,
const std::function<bool(binding::DLib*)>& was_loaded);
static inline Environment* from_timer_handle(uv_timer_t* handle); static inline Environment* from_timer_handle(uv_timer_t* handle);
inline uv_timer_t* timer_handle(); inline uv_timer_t* timer_handle();

View File

@ -2712,7 +2712,7 @@ static ParsePublicKeyResult TryParsePublicKey(
const BIOPointer& bp, const BIOPointer& bp,
const char* name, const char* name,
// NOLINTNEXTLINE(runtime/int) // NOLINTNEXTLINE(runtime/int)
std::function<EVP_PKEY*(const unsigned char** p, long l)> parse) { const std::function<EVP_PKEY*(const unsigned char** p, long l)>& parse) {
unsigned char* der_data; unsigned char* der_data;
long der_len; // NOLINT(runtime/int) long der_len; // NOLINT(runtime/int)

View File

@ -148,7 +148,7 @@ MaybeLocal<Value> Message::Deserialize(Environment* env,
} }
void Message::AddSharedArrayBuffer( void Message::AddSharedArrayBuffer(
SharedArrayBufferMetadataReference reference) { const SharedArrayBufferMetadataReference& reference) {
shared_array_buffers_.push_back(reference); shared_array_buffers_.push_back(reference);
} }

View File

@ -43,7 +43,7 @@ class Message : public MemoryRetainer {
// Internal method of Message that is called when a new SharedArrayBuffer // Internal method of Message that is called when a new SharedArrayBuffer
// object is encountered in the incoming value's structure. // object is encountered in the incoming value's structure.
void AddSharedArrayBuffer(SharedArrayBufferMetadataReference ref); void AddSharedArrayBuffer(const SharedArrayBufferMetadataReference& ref);
// Internal method of Message that is called once serialization finishes // Internal method of Message that is called once serialization finishes
// and that transfers ownership of `data` to this message. // and that transfers ownership of `data` to this message.
void AddMessagePort(std::unique_ptr<MessagePortData>&& data); void AddMessagePort(std::unique_ptr<MessagePortData>&& data);

View File

@ -181,7 +181,7 @@ void ClearMark(const FunctionCallbackInfo<Value>& args) {
} }
} }
inline uint64_t GetPerformanceMark(Environment* env, std::string name) { inline uint64_t GetPerformanceMark(Environment* env, const std::string& name) {
auto marks = env->performance_marks(); auto marks = env->performance_marks();
auto res = marks->find(name); auto res = marks->find(name);
return res != marks->end() ? res->second : 0; return res != marks->end() ? res->second : 0;

View File

@ -109,16 +109,16 @@ class URL {
} }
} }
explicit URL(std::string input) : explicit URL(const std::string& input) :
URL(input.c_str(), input.length()) {} URL(input.c_str(), input.length()) {}
URL(std::string input, const URL* base) : URL(const std::string& input, const URL* base) :
URL(input.c_str(), input.length(), base) {} URL(input.c_str(), input.length(), base) {}
URL(std::string input, const URL& base) : URL(const std::string& input, const URL& base) :
URL(input.c_str(), input.length(), &base) {} URL(input.c_str(), input.length(), &base) {}
URL(std::string input, std::string base) : URL(const std::string& input, const std::string& base) :
URL(input.c_str(), input.length(), base.c_str(), base.length()) {} URL(input.c_str(), input.length(), base.c_str(), base.length()) {}
int32_t flags() { int32_t flags() {

View File

@ -1,4 +1,6 @@
#include "sharedarraybuffer_metadata.h" #include "sharedarraybuffer_metadata.h"
#include <utility>
#include "base_object.h" #include "base_object.h"
#include "base_object-inl.h" #include "base_object-inl.h"
#include "node_errors.h" #include "node_errors.h"
@ -43,7 +45,7 @@ class SABLifetimePartner : public BaseObject {
Local<Object> obj, Local<Object> obj,
SharedArrayBufferMetadataReference r) SharedArrayBufferMetadataReference r)
: BaseObject(env, obj), : BaseObject(env, obj),
reference(r) { reference(std::move(r)) {
MakeWeak(); MakeWeak();
} }

View File

@ -40,6 +40,7 @@
#include <string> #include <string>
#include <array> #include <array>
#include <unordered_map> #include <unordered_map>
#include <utility>
namespace node { namespace node {
@ -450,7 +451,7 @@ template <typename T> inline void USE(T&&) {}
struct OnScopeLeave { struct OnScopeLeave {
std::function<void()> fn_; std::function<void()> fn_;
explicit OnScopeLeave(std::function<void()> fn) : fn_(fn) {} explicit OnScopeLeave(std::function<void()> fn) : fn_(std::move(fn)) {}
~OnScopeLeave() { fn_(); } ~OnScopeLeave() { fn_(); }
}; };

View File

@ -92,7 +92,7 @@ class SocketWrapper {
connected_(false), connected_(false),
sending_(false) { } sending_(false) { }
void Connect(std::string host, int port, bool v6 = false) { void Connect(const std::string& host, int port, bool v6 = false) {
closed_ = false; closed_ = false;
connection_failed_ = false; connection_failed_ = false;
connected_ = false; connected_ = false;
@ -114,7 +114,7 @@ class SocketWrapper {
ReadCallback); ReadCallback);
} }
void ExpectFailureToConnect(std::string host, int port) { void ExpectFailureToConnect(const std::string& host, int port) {
connected_ = false; connected_ = false;
connection_failed_ = false; connection_failed_ = false;
closed_ = false; closed_ = false;
@ -243,7 +243,7 @@ class ServerHolder {
: ServerHolder(has_targets, loop, HOST, port, nullptr) { } : ServerHolder(has_targets, loop, HOST, port, nullptr) { }
ServerHolder(bool has_targets, uv_loop_t* loop, ServerHolder(bool has_targets, uv_loop_t* loop,
const std::string host, int port, FILE* out); const std::string& host, int port, FILE* out);
InspectorSocketServer* operator->() { InspectorSocketServer* operator->() {
return server_.get(); return server_.get();
@ -350,7 +350,7 @@ class TestSocketServerDelegate : public SocketServerDelegate {
}; };
ServerHolder::ServerHolder(bool has_targets, uv_loop_t* loop, ServerHolder::ServerHolder(bool has_targets, uv_loop_t* loop,
const std::string host, int port, FILE* out) { const std::string& host, int port, FILE* out) {
std::vector<std::string> targets; std::vector<std::string> targets;
if (has_targets) if (has_targets)
targets = { MAIN_TARGET_ID }; targets = { MAIN_TARGET_ID };