1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bug where http response.readable was never set to false

Browse Source 
Closes GH-867.
This commit is contained in:
Abe Fettig 2011-03-31 17:02:14 -04:00 committed by Ryan Dahl
parent 0f47f63746
commit 83727a4c86
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/http.js
View File

@ -129,6 +129,7 @@ var parsers = new FreeList('parsers', 1000, function() {
}
if (!parser.incoming.upgrade) {
// For upgraded connections, also emit this after parser.execute
parser.incoming.readable = false;
parser.incoming.emit('end');
}
};

19
test/simple/test-http-response-readable.js Normal file
View File

@ -0,0 +1,19 @@
var common = require('../common');
var assert = require('assert');
var http = require('http');
var testServer = new http.Server(function(req, res) {
res.writeHead(200);
res.end('Hello world');
});
testServer.listen(common.PORT, function() {
http.get({ port: common.PORT }, function(res) {
assert.equal(res.readable, true, 'res.readable initially true');
res.on('end', function() {
assert.equal(res.readable, false, 'res.readable set to false after end');
testServer.close();
});
});
});