1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: fix building with system icu 76

Browse Source 
ICU 76 decided to reduce overlinking[^1] thus `icu-i18n` will no longer
add `icu-uc` when linking to shared libraries. This results in undefined
symbols/references when trying to build with system ICU 76.

[^1]: unicode-org/icu@199bc82

PR-URL: https://github.com/nodejs/node/pull/55563
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Michael Cho 2024-10-29 19:24:38 -04:00 committed by GitHub
parent 84fe809535
commit 81517facea
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
configure.py
View File

@ -1879,7 +1879,7 @@ def configure_intl(o):
elif with_intl == 'system-icu': elif with_intl == 'system-icu':
# ICU from pkg-config. # ICU from pkg-config.
o['variables']['v8_enable_i18n_support'] = 1 o['variables']['v8_enable_i18n_support'] = 1
pkgicu = pkg_config('icu-i18n') pkgicu = pkg_config(['icu-i18n', 'icu-uc'])
if not pkgicu[0]: if not pkgicu[0]:
error('''Could not load pkg-config data for "icu-i18n". error('''Could not load pkg-config data for "icu-i18n".
See above errors or the README.md.''') See above errors or the README.md.''')