1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: remove instructions to post CI links

Browse Source 
Remove instructions (in the Collaborator Guide) to post CI links. The
bot does that now.

PR-URL: https://github.com/nodejs/node/pull/28248
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Rich Trott 2019-06-15 19:30:55 -07:00
parent 779a243f86
commit 8030ca5b9e
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
COLLABORATOR_GUIDE.md
View File

@ -77,9 +77,8 @@ Please always remove it again as soon as the conditions are not met anymore.
### Handling own pull requests ### Handling own pull requests
When you open a pull request, [start a CI](#testing-and-ci) right away and post When you open a pull request, [start a CI](#testing-and-ci) right away. Later,
the link to it in a comment in the pull request. Later, after new code changes after new code changes or rebasing, start a new CI.
or rebasing, start a new CI.
As soon as the pull request is ready to land, please do so. This allows other As soon as the pull request is ready to land, please do so. This allows other
Collaborators to focus on other pull requests. If your pull request is not ready Collaborators to focus on other pull requests. If your pull request is not ready
@ -109,8 +108,8 @@ review by @-mention.
See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker). See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker).
If you are the first Collaborator to approve a pull request that has no CI yet, If you are the first Collaborator to approve a pull request that has no CI yet,
please [start one](#testing-and-ci). Post the link to the CI in the PR. Please please [start one](#testing-and-ci). Please also start a new CI if the PR
also start a new CI if the PR creator pushed new code since the last CI run. creator pushed new code since the last CI run.
### Consensus Seeking ### Consensus Seeking