tracing: remove shutdown-on-signal
This feature cannot be reasonably implemented this way without inherently being susceptible to race conditions that lead to hangs, crashes, etc. What’s more, implementing this for some signals only (and it can only be implemented for some signals at all) may lead to the impression that it is a guaranteed feature, when really consumers of the tracing output *need* to be able to handle abrupt ends meaningfully. Fixes: https://github.com/nodejs/node/issues/14802 Fixes: https://github.com/nodejs/node/issues/22528 PR-URL: https://github.com/nodejs/node/pull/22734 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
parent
23f8b02513
commit
80076cb1c7
@ -2053,7 +2053,6 @@ void SetupProcessObject(Environment* env,
|
||||
|
||||
void SignalExit(int signo) {
|
||||
uv_tty_reset_mode();
|
||||
v8_platform.StopTracingAgent();
|
||||
#ifdef __FreeBSD__
|
||||
// FreeBSD has a nasty bug, see RegisterSignalHandler for details
|
||||
struct sigaction sa;
|
||||
|
Loading…
x
Reference in New Issue
Block a user