1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: allow --perf-(basic-)?prof in NODE_OPTIONS

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17600
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This commit is contained in:
Leko 2017-12-11 13:05:54 +09:00 committed by Ruben Bridgewater
parent 4372185ef8
commit 7ff4888ed2
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/api/cli.md
View File

@ -475,6 +475,8 @@ Node options that are allowed are:
V8 options that are allowed are: V8 options that are allowed are:
- `--abort-on-uncaught-exception` - `--abort-on-uncaught-exception`
- `--max-old-space-size` - `--max-old-space-size`
- `--perf-basic-prof`
- `--perf-prof`
- `--stack-trace-limit` - `--stack-trace-limit`
### `NODE_PENDING_DEPRECATION=1` ### `NODE_PENDING_DEPRECATION=1`

2
src/node.cc
View File

@ -3530,6 +3530,8 @@ static void CheckIfAllowedInEnv(const char* exe, bool is_env,
"--icu-data-dir", "--icu-data-dir",
// V8 options (define with '_', which allows '-' or '_') // V8 options (define with '_', which allows '-' or '_')
"--perf_prof",
"--perf_basic_prof",
"--abort_on_uncaught_exception", "--abort_on_uncaught_exception",
"--max_old_space_size", "--max_old_space_size",
"--stack_trace_limit", "--stack_trace_limit",

9
test/parallel/test-cli-node-options.js
View File

@ -26,6 +26,15 @@ expect('--zero-fill-buffers', 'B\n');
expect('--v8-pool-size=10', 'B\n'); expect('--v8-pool-size=10', 'B\n');
expect('--trace-event-categories node', 'B\n'); expect('--trace-event-categories node', 'B\n');
if (!common.isWindows) {
expect('--perf-basic-prof', 'B\n');
}
if (common.isLinux && ['arm', 'x64', 'mips'].includes(process.arch)) {
// PerfJitLogger is only implemented in Linux.
expect('--perf-prof', 'B\n');
}
if (common.hasCrypto) { if (common.hasCrypto) {
expect('--use-openssl-ca', 'B\n'); expect('--use-openssl-ca', 'B\n');
expect('--use-bundled-ca', 'B\n'); expect('--use-bundled-ca', 'B\n');