1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: remove unnecessary checks

Browse Source 
This commit removes two truthy checks for object properties that
are immediately followed by a strict equality check. The other
item in the comparison is guaranteed to be a function by this
point in the code, so the truthy check is redundant.

PR-URL: https://github.com/nodejs/node/pull/9330
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
cjihrig 2016-10-27 17:37:40 -04:00
parent feb3531d91
commit 7f909c3b79
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/events.js
View File

@ -327,7 +327,7 @@ EventEmitter.prototype.removeListener =
if (!list)
return this;
if (list === listener || (list.listener && list.listener === listener)) {
if (list === listener || list.listener === listener) {
if (--this._eventsCount === 0)
this._events = new EventHandlers();
else {
@ -339,8 +339,7 @@ EventEmitter.prototype.removeListener =
position = -1;
for (i = list.length; i-- > 0;) {
if (list[i] === listener ||
(list[i].listener && list[i].listener === listener)) {
if (list[i] === listener || list[i].listener === listener) {
originalListener = list[i].listener;
position = i;
break;