1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

inspector: get rid of the make_unique

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/20895
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This commit is contained in:
Eugene Ostroukhov 2018-05-22 14:20:24 -07:00
parent 23a56e0c28
commit 7f610a1eec
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/inspector/tracing_agent.cc
View File

@ -56,7 +56,7 @@ TracingAgent::~TracingAgent() {
} }
void TracingAgent::Wire(UberDispatcher* dispatcher) { void TracingAgent::Wire(UberDispatcher* dispatcher) {
frontend_ = std::make_unique<NodeTracing::Frontend>(dispatcher->channel()); frontend_.reset(new NodeTracing::Frontend(dispatcher->channel()));
NodeTracing::Dispatcher::wire(dispatcher, this); NodeTracing::Dispatcher::wire(dispatcher, this);
} }
@ -77,7 +77,9 @@ DispatchResponse TracingAgent::start(
return DispatchResponse::Error("At least one category should be enabled"); return DispatchResponse::Error("At least one category should be enabled");
trace_writer_ = env_->tracing_agent()->AddClient( trace_writer_ = env_->tracing_agent()->AddClient(
categories_set, std::make_unique<InspectorTraceWriter>(frontend_.get())); categories_set,
std::unique_ptr<InspectorTraceWriter>(
new InspectorTraceWriter(frontend_.get())));
return DispatchResponse::OK(); return DispatchResponse::OK();
} }

4
src/inspector_agent.cc
View File

@ -198,8 +198,8 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel,
std::unique_ptr<InspectorSessionDelegate> delegate) std::unique_ptr<InspectorSessionDelegate> delegate)
: delegate_(std::move(delegate)) { : delegate_(std::move(delegate)) {
session_ = inspector->connect(1, this, StringView()); session_ = inspector->connect(1, this, StringView());
node_dispatcher_ = std::make_unique<protocol::UberDispatcher>(this); node_dispatcher_.reset(new protocol::UberDispatcher(this));
tracing_agent_ = std::make_unique<protocol::TracingAgent>(env); tracing_agent_.reset(new protocol::TracingAgent(env));
tracing_agent_->Wire(node_dispatcher_.get()); tracing_agent_->Wire(node_dispatcher_.get());
} }