From 7f2c9ba1ac343ebdd3d4fbe27757847555bf141d Mon Sep 17 00:00:00 2001 From: Junshu Okamoto Date: Fri, 9 Sep 2016 14:13:46 -0700 Subject: [PATCH] test: refector parallel/test-http.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: https://github.com/nodejs/node/pull/8471 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- test/parallel/test-http.js | 45 +++++++++++++++++++------------------- 1 file changed, 22 insertions(+), 23 deletions(-) diff --git a/test/parallel/test-http.js b/test/parallel/test-http.js index 102567fc2b4..f755bca8bc7 100644 --- a/test/parallel/test-http.js +++ b/test/parallel/test-http.js @@ -1,30 +1,30 @@ 'use strict'; require('../common'); -var assert = require('assert'); -var http = require('http'); -var url = require('url'); +const assert = require('assert'); +const http = require('http'); +const url = require('url'); var responses_sent = 0; var responses_recvd = 0; var body0 = ''; var body1 = ''; -var server = http.Server(function(req, res) { - if (responses_sent == 0) { - assert.equal('GET', req.method); - assert.equal('/hello', url.parse(req.url).pathname); +const server = http.Server(function(req, res) { + if (responses_sent === 0) { + assert.strictEqual('GET', req.method); + assert.strictEqual('/hello', url.parse(req.url).pathname); console.dir(req.headers); - assert.equal(true, 'accept' in req.headers); - assert.equal('*/*', req.headers['accept']); + assert.strictEqual(true, 'accept' in req.headers); + assert.strictEqual('*/*', req.headers['accept']); - assert.equal(true, 'foo' in req.headers); - assert.equal('bar', req.headers['foo']); + assert.strictEqual(true, 'foo' in req.headers); + assert.strictEqual('bar', req.headers['foo']); } - if (responses_sent == 1) { - assert.equal('POST', req.method); - assert.equal('/world', url.parse(req.url).pathname); + if (responses_sent === 1) { + assert.strictEqual('POST', req.method); + assert.strictEqual('/world', url.parse(req.url).pathname); this.close(); } @@ -41,14 +41,14 @@ var server = http.Server(function(req, res) { server.listen(0); server.on('listening', function() { - var agent = new http.Agent({ port: this.address().port, maxSockets: 1 }); + const agent = new http.Agent({ port: this.address().port, maxSockets: 1 }); http.get({ port: this.address().port, path: '/hello', headers: {'Accept': '*/*', 'Foo': 'bar'}, agent: agent }, function(res) { - assert.equal(200, res.statusCode); + assert.strictEqual(200, res.statusCode); responses_recvd += 1; res.setEncoding('utf8'); res.on('data', function(chunk) { body0 += chunk; }); @@ -56,13 +56,13 @@ server.on('listening', function() { }); setTimeout(function() { - var req = http.request({ + const req = http.request({ port: server.address().port, method: 'POST', path: '/world', agent: agent }, function(res) { - assert.equal(200, res.statusCode); + assert.strictEqual(200, res.statusCode); responses_recvd += 1; res.setEncoding('utf8'); res.on('data', function(chunk) { body1 += chunk; }); @@ -74,12 +74,11 @@ server.on('listening', function() { process.on('exit', function() { console.error('responses_recvd: ' + responses_recvd); - assert.equal(2, responses_recvd); + assert.strictEqual(2, responses_recvd); console.error('responses_sent: ' + responses_sent); - assert.equal(2, responses_sent); + assert.strictEqual(2, responses_sent); - assert.equal('The path was /hello', body0); - assert.equal('The path was /world', body1); + assert.strictEqual('The path was /hello', body0); + assert.strictEqual('The path was /world', body1); }); -