1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: track callback invocations

Browse Source 
Use `common.mustCall()` and `common.mustNotCall()` to check that
callbacks are invoked the expected number of times in
test-net-listen-shared-ports.

PR-URL: https://github.com/nodejs/node/pull/13010
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This commit is contained in:
Rich Trott 2017-05-12 17:01:13 -07:00 committed by Anna Henningsen
parent 28ddac2ec2
commit 7e5ed8bad9
No known key found for this signature in database
GPG Key ID: D8B9F5AEAE84E4CF
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
test/sequential/test-net-listen-shared-ports.js
View File

@ -28,19 +28,19 @@ const net = require('net');
if (cluster.isMaster) {
const worker1 = cluster.fork();
worker1.on('message', function(msg) {
worker1.on('message', common.mustCall(function(msg) {
assert.strictEqual(msg, 'success');
const worker2 = cluster.fork();
worker2.on('message', function(msg) {
worker2.on('message', common.mustCall(function(msg) {
assert.strictEqual(msg, 'server2:EADDRINUSE');
worker1.kill();
worker2.kill();
});
});
}));
}));
} else {
const server1 = net.createServer(common.noop);
const server2 = net.createServer(common.noop);
const server1 = net.createServer(common.mustNotCall());
const server2 = net.createServer(common.mustNotCall());
server1.on('error', function(err) {
// no errors expected
@ -56,10 +56,12 @@ if (cluster.isMaster) {
host: 'localhost',
port: common.PORT,
exclusive: false
}, function() {
server2.listen({port: common.PORT + 1, exclusive: true}, function() {
// the first worker should succeed
process.send('success');
});
});
}, common.mustCall(function() {
server2.listen({port: common.PORT + 1, exclusive: true},
common.mustCall(function() {
// the first worker should succeed
process.send('success');
})
);
}));
}