1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>

Browse Source 
Refs: https://github.com/nodejs/node/pull/57578
PR-URL: https://github.com/nodejs/node/pull/57733
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
This commit is contained in:
Aditi 2025-04-05 06:31:08 +05:30 committed by GitHub
parent 054371dc90
commit 7e43337fdd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/node_messaging.cc
View File

@ -27,6 +27,7 @@ using v8::Isolate;
using v8::Just;
using v8::JustVoid;
using v8::Local;
using v8::LocalVector;
using v8::Maybe;
using v8::MaybeLocal;
using v8::Nothing;
@ -74,7 +75,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
Message* m,
Environment* env,
const std::vector<BaseObjectPtr<BaseObject>>& host_objects,
const std::vector<Local<SharedArrayBuffer>>& shared_array_buffers,
const LocalVector<SharedArrayBuffer>& shared_array_buffers,
const std::vector<CompiledWasmModule>& wasm_modules,
const std::optional<SharedValueConveyor>& shared_value_conveyor)
: env_(env),
@ -129,7 +130,7 @@ class DeserializerDelegate : public ValueDeserializer::Delegate {
private:
Environment* env_;
const std::vector<BaseObjectPtr<BaseObject>>& host_objects_;
const std::vector<Local<SharedArrayBuffer>>& shared_array_buffers_;
const LocalVector<SharedArrayBuffer>& shared_array_buffers_;
const std::vector<CompiledWasmModule>& wasm_modules_;
const std::optional<SharedValueConveyor>& shared_value_conveyor_;
};
@ -188,7 +189,7 @@ MaybeLocal<Value> Message::Deserialize(Environment* env,
}
transferables_.clear();
std::vector<Local<SharedArrayBuffer>> shared_array_buffers;
LocalVector<SharedArrayBuffer> shared_array_buffers(env->isolate());
// Attach all transferred SharedArrayBuffers to their new Isolate.
for (uint32_t i = 0; i < shared_array_buffers_.size(); ++i) {
Local<SharedArrayBuffer> sab =
@ -477,7 +478,7 @@ Maybe<bool> Message::Serialize(Environment* env,
ValueSerializer serializer(env->isolate(), &delegate);
delegate.serializer = &serializer;
std::vector<Local<ArrayBuffer>> array_buffers;
LocalVector<ArrayBuffer> array_buffers(env->isolate());
for (uint32_t i = 0; i < transfer_list_v.length(); ++i) {
Local<Value> entry_val = transfer_list_v[i];
if (!entry_val->IsObject()) {
@ -999,7 +1000,7 @@ static Maybe<bool> ReadIterable(Environment* env,
return Nothing<bool>();
if (!next->IsFunction()) return Just(false);
std::vector<Local<Value>> entries;
LocalVector<Value> entries(isolate);
while (env->can_call_into_js()) {
Local<Value> result;
if (!next.As<Function>()->Call(context, iterator, 0, nullptr)