1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

assert: simplify logic of testing buffer equality

Browse Source 
Delegate buffer equality check to `buffer.equals()`

PR-URL: https://github.com/iojs/io.js/pull/1171
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Christian Vaagland Tellnes <christian@tellnes.com>
This commit is contained in:
Alex Yursha 2015-03-17 17:12:51 +03:00 committed by Brendan Ashworth
parent 269e46be37
commit 7dd5e824be
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/assert.js
View File

@ -25,6 +25,7 @@
'use strict'; 'use strict';
// UTILITY // UTILITY
const compare = process.binding('buffer').compare;
const util = require('util'); const util = require('util');
const pSlice = Array.prototype.slice; const pSlice = Array.prototype.slice;
@ -145,13 +146,7 @@ function _deepEqual(actual, expected, strict) {
if (actual === expected) { if (actual === expected) {
return true; return true;
} else if (actual instanceof Buffer && expected instanceof Buffer) { } else if (actual instanceof Buffer && expected instanceof Buffer) {
if (actual.length != expected.length) return false; return compare(actual, expected) === 0;
for (var i = 0; i < actual.length; i++) {
if (actual[i] !== expected[i]) return false;
}
return true;
// 7.2. If the expected value is a Date object, the actual value is // 7.2. If the expected value is a Date object, the actual value is
// equivalent if it is also a Date object that refers to the same time. // equivalent if it is also a Date object that refers to the same time.