1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: use countdown timer

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/17326
Refs: https://github.com/nodejs/node/issues/17169
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Mandeep Singh 2017-11-26 23:09:28 +05:30 committed by Ruben Bridgewater
parent 080a72c349
commit 7d2b08a3b5
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
test/parallel/test-http-response-status-message.js
View File

@ -24,8 +24,7 @@ require('../common');
const assert = require('assert'); const assert = require('assert');
const http = require('http'); const http = require('http');
const net = require('net'); const net = require('net');
const Countdown = require('../common/countdown');
let testsComplete = 0;
const testCases = [ const testCases = [
{ path: '/200', statusMessage: 'OK', { path: '/200', statusMessage: 'OK',
@ -59,6 +58,8 @@ const server = net.createServer(function(connection) {
}); });
}); });
const countdown = new Countdown(testCases.length, () => server.close());
function runTest(testCaseIndex) { function runTest(testCaseIndex) {
const testCase = testCases[testCaseIndex]; const testCase = testCases[testCaseIndex];
@ -71,12 +72,9 @@ function runTest(testCaseIndex) {
assert.strictEqual(testCase.statusMessage, response.statusMessage); assert.strictEqual(testCase.statusMessage, response.statusMessage);
response.on('end', function() { response.on('end', function() {
testsComplete++; countdown.dec();
if (testCaseIndex + 1 < testCases.length) { if (testCaseIndex + 1 < testCases.length) {
runTest(testCaseIndex + 1); runTest(testCaseIndex + 1);
} else {
server.close();
} }
}); });
@ -85,7 +83,3 @@ function runTest(testCaseIndex) {
} }
server.listen(0, function() { runTest(0); }); server.listen(0, function() { runTest(0); });
process.on('exit', function() {
assert.strictEqual(testCases.length, testsComplete);
});