1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: refactor benchmark/common.js

Browse Source 
Refactor benchmark/common.js to consistently use arrow functions for
anonymous callbacks and trailing commas.

PR-URL: https://github.com/nodejs/node/pull/25805
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Rich Trott 2019-01-29 15:05:16 -08:00
parent 0fd6e64503
commit 7c9fba30ef
1 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
benchmark/common.js
View File

@ -118,18 +118,19 @@ Benchmark.prototype.http = function(options, cb) {
self.config.benchmarker ||
self.extra_options.benchmarker ||
exports.default_http_benchmarker;
http_benchmarkers.run(http_options, function(error, code, used_benchmarker,
result, elapsed) {
if (cb) {
cb(code);
http_benchmarkers.run(
http_options, (error, code, used_benchmarker, result, elapsed) => {
if (cb) {
cb(code);
}
if (error) {
console.error(error);
process.exit(code || 1);
}
self.config.benchmarker = used_benchmarker;
self.report(result, elapsed);
}
if (error) {
console.error(error);
process.exit(code || 1);
}
self.config.benchmarker = used_benchmarker;
self.report(result, elapsed);
});
);
};
Benchmark.prototype._run = function() {
@ -139,7 +140,7 @@ Benchmark.prototype._run = function() {
process.send({
type: 'config',
name: this.name,
queueLength: this.queue.length
queueLength: this.queue.length,
});
}
@ -162,10 +163,10 @@ Benchmark.prototype._run = function() {
const child = child_process.fork(require.main.filename, childArgs, {
env: childEnv,
execArgv: self.flags.concat(process.execArgv)
execArgv: self.flags.concat(process.execArgv),
});
child.on('message', sendResult);
child.on('close', function(code) {
child.on('close', (code) => {
if (code) {
process.exit(code);
return;
@ -241,7 +242,7 @@ Benchmark.prototype.report = function(rate, elapsed) {
conf: this.config,
rate: rate,
time: elapsed[0] + elapsed[1] / 1e9,
type: 'report'
type: 'report',
});
};
@ -267,7 +268,7 @@ const urls = {
ws: 'ws://localhost:9229/f46db715-70df-43ad-a359-7f9949f39868',
javascript: 'javascript:alert("node is awesome");',
percent: 'https://%E4%BD%A0/foo',
dot: 'https://example.org/./a/../b/./c'
dot: 'https://example.org/./a/../b/./c',
};
exports.urls = urls;
@ -282,7 +283,7 @@ const searchParams = {
'foo=ghi&foo=jkl&foo=mno&foo=pqr&foo=stu&foo=vwxyz',
manypairs: 'a&b&c&d&e&f&g&h&i&j&k&l&m&n&o&p&q&r&s&t&u&v&w&x&y&z',
manyblankpairs: '&&&&&&&&&&&&&&&&&&&&&&&&',
altspaces: 'foo+bar=baz+quux&xyzzy+thud=quuy+quuz&abc=def+ghi'
altspaces: 'foo+bar=baz+quux&xyzzy+thud=quuy+quuz&abc=def+ghi',
};
exports.searchParams = searchParams;