1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: test each block in addon.md contains js & cc

Browse Source 
Allows more freedom in adding additional headings to addon.markdown,
otherwise it'll try and convert each block under a heading to a test
case. We need to have at least a .js and a .cc in order to have
something to test.

Fixes regression caused by adding a new 3rd-level heading in
d5863bc0f43a3778aa773d5f5f4ad08e1d7d7497

PR-URL: https://github.com/nodejs/node/pull/4411
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This commit is contained in:
Rod Vagg 2015-12-24 13:34:59 +11:00
parent 1c5d4f2453
commit 7c9cdb0882
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/doc/addon-verify.js
View File

@ -51,6 +51,12 @@ function once(fn) {
function verifyFiles(files, onprogress, ondone) { function verifyFiles(files, onprogress, ondone) {
var dir = path.resolve(verifyDir, 'doc-' + id++); var dir = path.resolve(verifyDir, 'doc-' + id++);
// must have a .cc and a .js to be a valid test
if (!Object.keys(files).some((name) => /\.cc$/.test(name)) ||
!Object.keys(files).some((name) => /\.js$/.test(name))) {
return;
}
files = Object.keys(files).map(function(name) { files = Object.keys(files).map(function(name) {
return { return {
path: path.resolve(dir, name), path: path.resolve(dir, name),
@ -58,6 +64,7 @@ function verifyFiles(files, onprogress, ondone) {
content: files[name] content: files[name]
}; };
}); });
files.push({ files.push({
path: path.resolve(dir, 'binding.gyp'), path: path.resolve(dir, 'binding.gyp'),
content: JSON.stringify({ content: JSON.stringify({