1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-file-write-stream3

Browse Source 
* use common.mustCall() to verify all tests have run
* eliminate unneeded removeTestFile()
* eliminate unneeded var leaking into global scope
* var -> const
* remove instance of let

PR-URL: https://github.com/nodejs/node/pull/6050
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Rich Trott 2016-04-04 23:08:45 -07:00
parent 937ac3760a
commit 7c9a691ee7
1 changed files with 9 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
test/parallel/test-file-write-stream3.js
View File

@ -5,21 +5,20 @@ const path = require('path');
const fs = require('fs'); const fs = require('fs');
var filepath = path.join(common.tmpDir, 'write_pos.txt'); const filepath = path.join(common.tmpDir, 'write_pos.txt');
const cb_expected = 'write open close write open close write open close '; const cb_expected = 'write open close write open close write open close ';
let cb_occurred = ''; var cb_occurred = '';
var fileDataInitial = 'abcdefghijklmnopqrstuvwxyz'; const fileDataInitial = 'abcdefghijklmnopqrstuvwxyz';
var fileDataExpected_1 = 'abcdefghijklmnopqrstuvwxyz'; const fileDataExpected_1 = 'abcdefghijklmnopqrstuvwxyz';
var fileDataExpected_2 = 'abcdefghij123456qrstuvwxyz'; const fileDataExpected_2 = 'abcdefghij123456qrstuvwxyz';
var fileDataExpected_3 = 'abcdefghij\u2026\u2026qrstuvwxyz'; const fileDataExpected_3 = 'abcdefghij\u2026\u2026qrstuvwxyz';
process.on('exit', function() { process.on('exit', function() {
removeTestFile();
if (cb_occurred !== cb_expected) { if (cb_occurred !== cb_expected) {
console.log(' Test callback events missing or out of order:'); console.log(' Test callback events missing or out of order:');
console.log(' expected: %j', cb_expected); console.log(' expected: %j', cb_expected);
@ -30,12 +29,6 @@ process.on('exit', function() {
} }
}); });
function removeTestFile() {
try {
fs.unlinkSync(filepath);
} catch (ex) { }
}
common.refreshTmpDir(); common.refreshTmpDir();
@ -164,20 +157,14 @@ function run_test_3() {
} }
function run_test_4() { const run_test_4 = common.mustCall(function() {
var options;
options = { start: -5,
flags: 'r+' };
// Error: start must be >= zero // Error: start must be >= zero
assert.throws( assert.throws(
function() { function() {
file = fs.createWriteStream(filepath, options); fs.createWriteStream(filepath, { start: -5, flags: 'r+' });
}, },
/"start" must be/ /"start" must be/
); );
});
}
run_test_1(); run_test_1();