1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sockets should never be attached to a ClientRequest before nextTick().

Browse Source 
This way the API for interacting directly with the socket object is
consistent before and after the Agent pool is exhausted.

Fixes #1601.
This commit is contained in:
Mikeal Rogers 2011-08-28 15:51:40 -07:00 committed by Ryan Dahl
parent 1a0edbca86
commit 7c87e092fb
1 changed files with 125 additions and 125 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/http2.js
View File

@ -1070,9 +1070,9 @@ ClientRequest.prototype.abort = function() {
}; };
ClientRequest.prototype.onSocket = function(socket) { ClientRequest.prototype.onSocket = function(socket) {
var parser = parsers.alloc();
var req = this; var req = this;
process.nextTick(function () {
var parser = parsers.alloc();
req.socket = socket; req.socket = socket;
req.connection = socket; req.connection = socket;
parser.reinitialize('response'); parser.reinitialize('response');
@ -1209,9 +1209,9 @@ ClientRequest.prototype.onSocket = function(socket) {
return isHeadResponse; return isHeadResponse;
}; };
process.nextTick(function() {
req.emit('socket', socket); req.emit('socket', socket);
}); });
}; };
ClientRequest.prototype._deferToConnect = function(method, arguments, cb) { ClientRequest.prototype._deferToConnect = function(method, arguments, cb) {
// This function is for calls that need to happen once the socket is // This function is for calls that need to happen once the socket is