1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve code in test-vm-symbols

Browse Source 
* use const instead of var
* use assert.strictEqual instead of assert.equal

PR-URL: https://github.com/nodejs/node/pull/10429
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
Adrian Estrada 2016-12-23 14:01:17 -05:00 committed by Luigi Pinca
parent f2ef850f11
commit 7c0d5d5fd9
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
test/parallel/test-vm-symbols.js
View File

@ -1,11 +1,11 @@
'use strict'; 'use strict';
require('../common'); require('../common');
var assert = require('assert'); const assert = require('assert');
var vm = require('vm'); const vm = require('vm');
var symbol = Symbol(); const symbol = Symbol();
function Document() { function Document() {
this[symbol] = 'foo'; this[symbol] = 'foo';
@ -15,11 +15,11 @@ Document.prototype.getSymbolValue = function() {
return this[symbol]; return this[symbol];
}; };
var context = new Document(); const context = new Document();
vm.createContext(context); vm.createContext(context);
assert.equal(context.getSymbolValue(), 'foo', assert.strictEqual(context.getSymbolValue(), 'foo',
'should return symbol-keyed value from the outside'); 'should return symbol-keyed value from the outside');
assert.equal(vm.runInContext('this.getSymbolValue()', context), 'foo', assert.strictEqual(vm.runInContext('this.getSymbolValue()', context), 'foo',
'should return symbol-keyed value from the inside'); 'should return symbol-keyed value from the inside');