1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

benchmark: refactor prims-and-objs-big-array-set

Browse Source 
This is a minor refactor of
benchmark/assert/deepequal-prims-and-objs-big-array-set.js to
reduce exceptions that need to be made for lint compliance.

PR-URL: https://github.com/nodejs/node/pull/21030
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Rich Trott 2018-05-30 03:45:24 +00:00
parent 07d3c55eca
commit 7bfc00d848
1 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
benchmark/assert/deepequal-prims-and-objs-big-array-set.js
View File

@ -1,7 +1,8 @@
'use strict'; 'use strict';
const common = require('../common.js'); const common = require('../common.js');
const assert = require('assert'); const { deepEqual, deepStrictEqual, notDeepEqual, notDeepStrictEqual } =
require('assert');
const primValues = { const primValues = {
'null': null, 'null': null,
@ -61,32 +62,28 @@ function main({ n, len, primitive, method }) {
// Empty string falls through to next line as default, mostly for tests. // Empty string falls through to next line as default, mostly for tests.
case '': case '':
case 'deepEqual_Array': case 'deepEqual_Array':
// eslint-disable-next-line no-restricted-properties run(deepEqual, n, actual, expected);
run(assert.deepEqual, n, actual, expected);
break; break;
case 'deepStrictEqual_Array': case 'deepStrictEqual_Array':
run(assert.deepStrictEqual, n, actual, expected); run(deepStrictEqual, n, actual, expected);
break; break;
case 'notDeepEqual_Array': case 'notDeepEqual_Array':
// eslint-disable-next-line no-restricted-properties run(notDeepEqual, n, actual, expectedWrong);
run(assert.notDeepEqual, n, actual, expectedWrong);
break; break;
case 'notDeepStrictEqual_Array': case 'notDeepStrictEqual_Array':
run(assert.notDeepStrictEqual, n, actual, expectedWrong); run(notDeepStrictEqual, n, actual, expectedWrong);
break; break;
case 'deepEqual_Set': case 'deepEqual_Set':
// eslint-disable-next-line no-restricted-properties run(deepEqual, n, actualSet, expectedSet);
run(assert.deepEqual, n, actualSet, expectedSet);
break; break;
case 'deepStrictEqual_Set': case 'deepStrictEqual_Set':
run(assert.deepStrictEqual, n, actualSet, expectedSet); run(deepStrictEqual, n, actualSet, expectedSet);
break; break;
case 'notDeepEqual_Set': case 'notDeepEqual_Set':
// eslint-disable-next-line no-restricted-properties run(notDeepEqual, n, actualSet, expectedWrongSet);
run(assert.notDeepEqual, n, actualSet, expectedWrongSet);
break; break;
case 'notDeepStrictEqual_Set': case 'notDeepStrictEqual_Set':
run(assert.notDeepStrictEqual, n, actualSet, expectedWrongSet); run(notDeepStrictEqual, n, actualSet, expectedWrongSet);
break; break;
default: default:
throw new Error(`Unsupported method "${method}"`); throw new Error(`Unsupported method "${method}"`);