errors: fix ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK
This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the "INTST" vs "INST") in 921fb84687fb8135075c1f001383e9b0b863f4b5 (PR #16874) and then had documentation and implementation removed under the old name in 6e1c25c45672b70f4b6c6c8af56d9c0762bfae04 (PR #18857), as it appeared unused. This error code never worked or was documented under the mistyped name ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix. Refs: https://github.com/nodejs/node/issues/21440 Refs: https://github.com/nodejs/node/pull/21470 Refs: https://github.com/nodejs/node/pull/16874 Refs: https://github.com/nodejs/node/pull/18857 PR-URL: https://github.com/nodejs/node/pull/21493 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This commit is contained in:
parent
b87b164565
commit
7bdc694267
@ -1330,6 +1330,14 @@ strict compliance with the API specification (which in some cases may accept
|
||||
`func(undefined)` and `func()` are treated identically, and the
|
||||
[`ERR_INVALID_ARG_TYPE`][] error code may be used instead.
|
||||
|
||||
<a id="ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK"></a>
|
||||
### ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK
|
||||
|
||||
> Stability: 1 - Experimental
|
||||
|
||||
An [ES6 module][] loader hook specified `format: 'dynamic'` but did not provide
|
||||
a `dynamicInstantiate` hook.
|
||||
|
||||
<a id="ERR_MISSING_MESSAGE_PORT_IN_TRANSFER_LIST"></a>
|
||||
### ERR_MISSING_MESSAGE_PORT_IN_TRANSFER_LIST
|
||||
|
||||
|
@ -739,6 +739,9 @@ E('ERR_MISSING_ARGS',
|
||||
}
|
||||
return `${msg} must be specified`;
|
||||
}, TypeError);
|
||||
E('ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK',
|
||||
'The ES Module loader may not return a format of \'dynamic\' when no ' +
|
||||
'dynamicInstantiate function was provided', Error);
|
||||
E('ERR_MISSING_MODULE', 'Cannot find module %s', Error);
|
||||
E('ERR_MODULE_RESOLUTION_LEGACY',
|
||||
'%s not found by import in %s.' +
|
||||
|
@ -5,7 +5,7 @@ const {
|
||||
ERR_INVALID_RETURN_PROPERTY,
|
||||
ERR_INVALID_RETURN_PROPERTY_VALUE,
|
||||
ERR_INVALID_RETURN_VALUE,
|
||||
ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK,
|
||||
ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK,
|
||||
ERR_UNKNOWN_MODULE_FORMAT
|
||||
} = require('internal/errors').codes;
|
||||
const { URL } = require('url');
|
||||
@ -118,7 +118,7 @@ class Loader {
|
||||
let loaderInstance;
|
||||
if (format === 'dynamic') {
|
||||
if (typeof this._dynamicInstantiate !== 'function')
|
||||
throw new ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK();
|
||||
throw new ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK();
|
||||
|
||||
loaderInstance = async (url) => {
|
||||
debug(`Translating dynamic ${url}`);
|
||||
|
Loading…
x
Reference in New Issue
Block a user