1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fs: move SyncWriteStream to end-of-life

Browse Source 
This was deprecated in 8.x or 9.x. It was never intended for
public use.

PR-URL: https://github.com/nodejs/node/pull/20735
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
James M Snell 2018-05-14 17:55:46 -07:00
parent 4d00cd4ce7
commit 7bd48896e9
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
doc/api/deprecations.md
View File

@ -528,10 +528,11 @@ The [`util._extend()`][] API has been deprecated.
<a id="DEP0061"></a> <a id="DEP0061"></a>
### DEP0061: fs.SyncWriteStream ### DEP0061: fs.SyncWriteStream
Type: Runtime Type: End-of-Life
The `fs.SyncWriteStream` class was never intended to be a publicly accessible The `fs.SyncWriteStream` class was never intended to be a publicly accessible
API. No alternative API is available. Please use a userland alternative. API and has been removed. No alternative API is available. Please use a userland
alternative.
<a id="DEP0062"></a> <a id="DEP0062"></a>
### DEP0062: node --debug ### DEP0062: node --debug

11
lib/fs.js
View File

@ -2360,14 +2360,3 @@ WriteStream.prototype.close = function(cb) {
// There is no shutdown() for files. // There is no shutdown() for files.
WriteStream.prototype.destroySoon = WriteStream.prototype.end; WriteStream.prototype.destroySoon = WriteStream.prototype.end;
// SyncWriteStream is internal. DO NOT USE.
// This undocumented API was never intended to be made public.
var SyncWriteStream = internalFS.SyncWriteStream;
Object.defineProperty(fs, 'SyncWriteStream', {
configurable: true,
get: internalUtil.deprecate(() => SyncWriteStream,
'fs.SyncWriteStream is deprecated.', 'DEP0061'),
set: internalUtil.deprecate((val) => { SyncWriteStream = val; },
'fs.SyncWriteStream is deprecated.', 'DEP0061')
});