1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: increase coverage for stream's duplex

Browse Source 
Make use of Arrow function.
Add a small test and this file's coverage is 100%.
a647d82f83/lib/_stream_duplex.js (L25)
Coverage: https://coverage.nodejs.org/coverage-067be658f966dafe/root/_stream_duplex.js.html

PR-URL: https://github.com/nodejs/node/pull/10963
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit is contained in:
abouthiroppy 2017-01-23 22:27:00 +09:00 committed by James M Snell
parent 3268863ebc
commit 7ad012dbb1
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/parallel/test-stream-duplex.js
View File

@ -5,27 +5,28 @@ const Duplex = require('stream').Transform;
const stream = new Duplex({ objectMode: true });
assert(Duplex() instanceof Duplex);
assert(stream._readableState.objectMode);
assert(stream._writableState.objectMode);
let written;
let read;
stream._write = function(obj, _, cb) {
stream._write = (obj, _, cb) => {
written = obj;
cb();
};
stream._read = function() {};
stream._read = () => {};
stream.on('data', function(obj) {
stream.on('data', (obj) => {
read = obj;
});
stream.push({ val: 1 });
stream.end({ val: 2 });
process.on('exit', function() {
process.on('exit', () => {
assert.strictEqual(read.val, 1);
assert.strictEqual(written.val, 2);
});