1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fs: simplify fs.promises warning logic

Browse Source 
fs.promises is lazy loaded. Instead of using a seaparate
Boolean flag to track whether or not it has been loaded, just
inspect the state of the lazy loaded module itself.

PR-URL: https://github.com/nodejs/node/pull/24788
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This commit is contained in:
cjihrig 2018-12-02 12:08:26 -05:00 committed by Rich Trott
parent 585380d233
commit 7ac939e106
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/fs.js
View File

@ -86,12 +86,11 @@ const {
validateUint32 validateUint32
} = require('internal/validators'); } = require('internal/validators');
let promisesWarn = true;
let truncateWarn = true; let truncateWarn = true;
let fs; let fs;
// Lazy loaded // Lazy loaded
let promises; let promises = null;
let watchers; let watchers;
let ReadFileContext; let ReadFileContext;
let ReadStream; let ReadStream;
@ -1931,9 +1930,8 @@ Object.defineProperties(fs, {
configurable: true, configurable: true,
enumerable: false, enumerable: false,
get() { get() {
if (promisesWarn) { if (promises === null) {
promises = require('internal/fs/promises'); promises = require('internal/fs/promises');
promisesWarn = false;
process.emitWarning('The fs.promises API is experimental', process.emitWarning('The fs.promises API is experimental',
'ExperimentalWarning'); 'ExperimentalWarning');
} }