1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: use unique_ptr for obj in SetWeak lambda

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/23117
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Daniel Bevenius 2018-09-27 08:36:01 +02:00
parent 1be804d625
commit 7ac109df10
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/base_object-inl.h
View File

@ -95,13 +95,12 @@ void BaseObject::MakeWeak() {
persistent_handle_.SetWeak( persistent_handle_.SetWeak(
this, this,
[](const v8::WeakCallbackInfo<BaseObject>& data) { [](const v8::WeakCallbackInfo<BaseObject>& data) {
BaseObject* obj = data.GetParameter(); std::unique_ptr<BaseObject> obj(data.GetParameter());
// Clear the persistent handle so that ~BaseObject() doesn't attempt // Clear the persistent handle so that ~BaseObject() doesn't attempt
// to mess with internal fields, since the JS object may have // to mess with internal fields, since the JS object may have
// transitioned into an invalid state. // transitioned into an invalid state.
// Refs: https://github.com/nodejs/node/issues/18897 // Refs: https://github.com/nodejs/node/issues/18897
obj->persistent_handle_.Reset(); obj->persistent_handle_.Reset();
delete obj;
}, v8::WeakCallbackType::kParameter); }, v8::WeakCallbackType::kParameter);
} }