1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tools: enable no-useless-return eslint rule

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/12577
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This commit is contained in:
cjihrig 2017-04-21 18:50:52 -04:00
parent 0084260448
commit 7a4d383c75
6 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc.yaml
View File

@ -50,6 +50,7 @@ rules:
no-unused-labels: 2 no-unused-labels: 2
no-useless-call: 2 no-useless-call: 2
no-useless-escape: 2 no-useless-escape: 2
no-useless-return: 2
no-void: 2 no-void: 2
no-with: 2 no-with: 2

1
doc/api/errors.md
View File

@ -64,6 +64,7 @@ Errors that occur within _Asynchronous APIs_ may be reported in multiple ways:
argument is not `null` and is an instance of `Error`, then an error occurred argument is not `null` and is an instance of `Error`, then an error occurred
that should be handled. that should be handled.
<!-- eslint-disable no-useless-return -->
```js ```js
const fs = require('fs'); const fs = require('fs');
fs.readFile('a file that does not exist', (err, data) => { fs.readFile('a file that does not exist', (err, data) => {

1
doc/api/stream.md
View File

@ -1566,6 +1566,7 @@ unexpected and inconsistent behavior depending on whether the stream is
operating in flowing or paused mode. Using the `'error'` event ensures operating in flowing or paused mode. Using the `'error'` event ensures
consistent and predictable handling of errors. consistent and predictable handling of errors.
<!-- eslint-disable no-useless-return -->
```js ```js
const Readable = require('stream').Readable; const Readable = require('stream').Readable;

1
lib/dgram.js
View File

@ -307,7 +307,6 @@ function enqueue(self, toEnqueue) {
self.once('listening', onListenSuccess); self.once('listening', onListenSuccess);
} }
self._queue.push(toEnqueue); self._queue.push(toEnqueue);
return;
} }

4
test/parallel/test-require-symlink.js
View File

@ -30,9 +30,9 @@ if (common.isWindows) {
if (err || !o.includes('SeCreateSymbolicLinkPrivilege')) { if (err || !o.includes('SeCreateSymbolicLinkPrivilege')) {
common.skip('insufficient privileges'); common.skip('insufficient privileges');
return; return;
} else {
test();
} }
test();
}); });
} else { } else {
test(); test();

4
tools/doc/json.js
View File

@ -243,7 +243,6 @@ function processList(section) {
current.options.push(n); current.options.push(n);
current = n; current = n;
} }
return;
} else if (type === 'list_item_end') { } else if (type === 'list_item_end') {
if (!current) { if (!current) {
throw new Error('invalid list - end without current item\n' + throw new Error('invalid list - end without current item\n' +
@ -516,9 +515,6 @@ function finishSection(section, parent) {
parent[k] = parent[k].concat(section[k]); parent[k] = parent[k].concat(section[k]);
} else if (!parent[k]) { } else if (!parent[k]) {
parent[k] = section[k]; parent[k] = section[k];
} else {
// parent already has, and it's not an array.
return;
} }
} }
}); });