1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: improve the code in test-fs-read-stream

Browse Source 
* use const and let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10556
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This commit is contained in:
Adrian Estrada 2017-01-02 22:22:29 -05:00 committed by Italo A. Casas
parent 275362ae3b
commit 7a46b992d2
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/parallel/test-fs-read-stream-fd.js
View File

@ -3,21 +3,20 @@ const common = require('../common');
const fs = require('fs'); const fs = require('fs');
const assert = require('assert'); const assert = require('assert');
const path = require('path'); const path = require('path');
var file = path.join(common.tmpDir, '/read_stream_fd_test.txt'); const file = path.join(common.tmpDir, '/read_stream_fd_test.txt');
var input = 'hello world'; const input = 'hello world';
var output = '';
var fd, stream;
let output = '';
common.refreshTmpDir(); common.refreshTmpDir();
fs.writeFileSync(file, input); fs.writeFileSync(file, input);
fd = fs.openSync(file, 'r');
stream = fs.createReadStream(null, { fd: fd, encoding: 'utf8' }); const fd = fs.openSync(file, 'r');
stream.on('data', function(data) { const stream = fs.createReadStream(null, { fd: fd, encoding: 'utf8' });
stream.on('data', (data) => {
output += data; output += data;
}); });
process.on('exit', function() { process.on('exit', () => {
fs.unlinkSync(file); assert.strictEqual(output, input);
assert.equal(output, input);
}); });