1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: refactor test-fs-write.js

Browse Source 
Changed var to const and equal to strictEqual

PR-URL: https://github.com/nodejs/node/pull/9982
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
hirabhullar 2016-12-01 09:34:21 -08:00 committed by Rich Trott
parent 108314b48f
commit 7a23c0a800
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
test/parallel/test-fs-write.js
View File

@ -1,13 +1,13 @@
'use strict'; 'use strict';
var common = require('../common'); const common = require('../common');
var assert = require('assert'); const assert = require('assert');
var path = require('path'); const path = require('path');
var Buffer = require('buffer').Buffer; const Buffer = require('buffer').Buffer;
var fs = require('fs'); const fs = require('fs');
var fn = path.join(common.tmpDir, 'write.txt'); const fn = path.join(common.tmpDir, 'write.txt');
var fn2 = path.join(common.tmpDir, 'write2.txt'); const fn2 = path.join(common.tmpDir, 'write2.txt');
var expected = 'ümlaut.'; const expected = 'ümlaut.';
var constants = fs.constants; const constants = fs.constants;
common.refreshTmpDir(); common.refreshTmpDir();
@ -15,12 +15,12 @@ fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) {
if (err) throw err; if (err) throw err;
console.log('open done'); console.log('open done');
fs.write(fd, '', 0, 'utf8', function(err, written) { fs.write(fd, '', 0, 'utf8', function(err, written) {
assert.equal(0, written); assert.strictEqual(0, written);
}); });
fs.write(fd, expected, 0, 'utf8', common.mustCall(function(err, written) { fs.write(fd, expected, 0, 'utf8', common.mustCall(function(err, written) {
console.log('write done'); console.log('write done');
if (err) throw err; if (err) throw err;
assert.equal(Buffer.byteLength(expected), written); assert.strictEqual(Buffer.byteLength(expected), written);
fs.closeSync(fd); fs.closeSync(fd);
const found = fs.readFileSync(fn, 'utf8'); const found = fs.readFileSync(fn, 'utf8');
console.log('expected: "%s"', expected); console.log('expected: "%s"', expected);
@ -36,12 +36,12 @@ fs.open(fn2, constants.O_CREAT | constants.O_WRONLY | constants.O_TRUNC, 0o644,
if (err) throw err; if (err) throw err;
console.log('open done'); console.log('open done');
fs.write(fd, '', 0, 'utf8', (err, written) => { fs.write(fd, '', 0, 'utf8', (err, written) => {
assert.equal(0, written); assert.strictEqual(0, written);
}); });
fs.write(fd, expected, 0, 'utf8', common.mustCall((err, written) => { fs.write(fd, expected, 0, 'utf8', common.mustCall((err, written) => {
console.log('write done'); console.log('write done');
if (err) throw err; if (err) throw err;
assert.equal(Buffer.byteLength(expected), written); assert.strictEqual(Buffer.byteLength(expected), written);
fs.closeSync(fd); fs.closeSync(fd);
const found = fs.readFileSync(fn2, 'utf8'); const found = fs.readFileSync(fn2, 'utf8');
console.log('expected: "%s"', expected); console.log('expected: "%s"', expected);