1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: relax expectations in test-icu-transcode

Browse Source 
Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252,
which is consistent with
[WHATWG spec](https://encoding.spec.whatwg.org/#names-and-labels). If
linked against Chromium's ICU, Node.js therefore fails
`test/parallel/test-icu-transcode`.

PR-URL: https://github.com/nodejs/node/pull/25866
Refs: https://github.com/nodejs/node/issues/25851
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This commit is contained in:
Yang Guo 2019-02-01 08:49:28 +01:00 committed by Daniel Bevenius
parent 1ac6ea2e6b
commit 793c63073a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/parallel/test-icu-transcode.js
View File

@ -7,15 +7,15 @@ if (!common.hasIntl)
const buffer = require('buffer');
const assert = require('assert');
const orig = Buffer.from('tést €', 'utf8');
const orig = Buffer.from('těst ☕', 'utf8');
// Test Transcoding
const tests = {
'latin1': [0x74, 0xe9, 0x73, 0x74, 0x20, 0x3f],
'latin1': [0x74, 0x3f, 0x73, 0x74, 0x20, 0x3f],
'ascii': [0x74, 0x3f, 0x73, 0x74, 0x20, 0x3f],
'ucs2': [0x74, 0x00, 0xe9, 0x00, 0x73,
'ucs2': [0x74, 0x00, 0x1b, 0x01, 0x73,
0x00, 0x74, 0x00, 0x20, 0x00,
0xac, 0x20]
0x15, 0x26]
};
for (const test in tests) {