From 7939a5e7088f1efc471efe2ee48575c2ae52b42a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marja=20H=C3=B6ltt=C3=A4?= Date: Tue, 19 Sep 2017 16:23:33 +0200 Subject: [PATCH] test: change test expectation for string decoder V8 has changed their invalid UTF-8 handling. See https://chromium-review.googlesource.com/c/v8/v8/+/671020 for more info PR-URL: https://github.com/nodejs/node/pull/16271 Reviewed-By: Ben Noordhuis Reviewed-By: Myles Borins --- test/parallel/test-string-decoder.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/parallel/test-string-decoder.js b/test/parallel/test-string-decoder.js index f1b11477008..9d1fe69a25d 100644 --- a/test/parallel/test-string-decoder.js +++ b/test/parallel/test-string-decoder.js @@ -69,7 +69,11 @@ test('utf-8', Buffer.from('E2B8CCB8', 'hex'), '\ufffd\u0338'); test('utf-8', Buffer.from('E2FBCC01', 'hex'), '\ufffd\ufffd\ufffd\u0001'); test('utf-8', Buffer.from('CCB8CDB9', 'hex'), '\u0338\u0379'); // CESU-8 of U+1D40D -test('utf-8', Buffer.from('EDA0B5EDB08D', 'hex'), '\ufffd\ufffd'); + +// V8 has changed their invalid UTF-8 handling, see +// https://chromium-review.googlesource.com/c/v8/v8/+/671020 for more info. +test('utf-8', Buffer.from('EDA0B5EDB08D', 'hex'), + '\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd'); // UCS-2 test('ucs2', Buffer.from('ababc', 'ucs2'), 'ababc');