1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

http2: store headersSent after stream destroyed

Browse Source 
Store headersSent directly on response state after finish event
is triggered, so that users can always access it.

PR-URL: https://github.com/nodejs/node/pull/15232
Fixes: https://github.com/nodejs/node/issues/15226
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This commit is contained in:
Anatoli Papirovski 2017-09-06 17:22:42 -04:00 committed by Ruben Bridgewater
parent 94be2b1793
commit 78fc726203
No known key found for this signature in database
GPG Key ID: F07496B3EB3C1762
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/internal/http2/compat.js
View File

@ -320,7 +320,7 @@ class Http2ServerResponse extends Stream {
get headersSent() {
const stream = this[kStream];
return stream.headersSent;
return stream !== undefined ? stream.headersSent : this[kState].headersSent;
}
get sendDate() {
@ -542,6 +542,7 @@ class Http2ServerResponse extends Stream {
if (code !== undefined)
state.closedCode = code;
state.closed = true;
state.headersSent = this[kStream].headersSent;
this.end();
this[kStream] = undefined;
this.emit('finish');

1
test/parallel/test-http2-compat-serverresponse-headers.js
View File

@ -88,6 +88,7 @@ server.listen(0, common.mustCall(function() {
response.on('finish', common.mustCall(function() {
assert.strictEqual(response.code, h2.constants.NGHTTP2_NO_ERROR);
assert.strictEqual(response.headersSent, true);
server.close();
}));
response.end();