1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

events: don't delete the listeners array

Browse Source 
The documentation implies that .removeAllListeners() leaves the listeners array
untouched. Make it so.
This commit is contained in:
Ben Noordhuis 2012-03-16 00:18:50 +01:00
parent f9aa01de32
commit 78dc13fbf9
2 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/events.js
View File

@ -203,8 +203,15 @@ EventEmitter.prototype.removeAllListeners = function(type) {
return this; return this;
} }
// does not use listeners(), so no side effect of creating _events[type] var events = this._events && this._events[type];
if (type && this._events && this._events[type]) this._events[type] = null; if (!events) return this;
if (isArray(events)) {
events.splice(0);
} else {
this._events[type] = null;
}
return this; return this;
}; };

10
test/simple/test-event-emitter-remove-all-listeners.js
View File

@ -29,10 +29,14 @@ function listener() {}
var e1 = new events.EventEmitter(); var e1 = new events.EventEmitter();
e1.on('foo', listener); e1.on('foo', listener);
e1.on('bar', listener); e1.on('bar', listener);
var fooListeners = e1.listeners('foo');
var barListeners = e1.listeners('bar');
e1.removeAllListeners('foo'); e1.removeAllListeners('foo');
assert.deepEqual([], e1.listeners('foo')); assert.deepEqual(e1.listeners('foo'), []);
assert.deepEqual([listener], e1.listeners('bar')); assert.deepEqual(e1.listeners('bar'), [listener]);
// identity check, the array should not change
assert.equal(e1.listeners('foo'), fooListeners);
assert.equal(e1.listeners('bar'), barListeners);
var e2 = new events.EventEmitter(); var e2 = new events.EventEmitter();
e2.on('foo', listener); e2.on('foo', listener);