test: check destroy hooks are called before exit

Verify that the destroy callback for a TCP server is called before exit
if it is closed in another destroy callback.

Fixes: https://github.com/nodejs/node/issues/13262
PR-URL: https://github.com/nodejs/node/pull/13369
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
This commit is contained in:
Anna Henningsen 2017-06-01 06:13:58 -06:00 committed by Trevor Norris
parent 1e44fd960f
commit 78b135806f
No known key found for this signature in database
GPG Key ID: 251CA676820DC7F3
2 changed files with 64 additions and 0 deletions

View File

@ -0,0 +1,37 @@
'use strict';
// Test that async ids that are added to the destroy queue while running a
// `destroy` callback are handled correctly.
const common = require('../common');
const assert = require('assert');
const async_hooks = require('async_hooks');
const initCalls = new Set();
let destroyResCallCount = 0;
let res2;
async_hooks.createHook({
init: common.mustCallAtLeast((id, provider, triggerId) => {
if (provider === 'foobar')
initCalls.add(id);
}, 2),
destroy: common.mustCallAtLeast((id) => {
if (!initCalls.has(id)) return;
switch (destroyResCallCount++) {
case 0:
// Trigger the second `destroy` call.
res2.emitDestroy();
break;
case 2:
assert.fail('More than 2 destroy() invocations');
break;
}
}, 2)
}).enable();
const res1 = new async_hooks.AsyncResource('foobar');
res2 = new async_hooks.AsyncResource('foobar');
res1.emitDestroy();
process.on('exit', () => assert.strictEqual(destroyResCallCount, 2));

View File

@ -0,0 +1,27 @@
'use strict';
// Regression test for https://github.com/nodejs/node/issues/13262
const common = require('../common');
const assert = require('assert');
const async_hooks = require('async_hooks');
let seenId, seenResource;
async_hooks.createHook({
init: common.mustCall((id, provider, triggerId, resource) => {
seenId = id;
seenResource = resource;
assert.strictEqual(provider, 'Immediate');
assert.strictEqual(triggerId, 1);
}),
before: common.mustNotCall(),
after: common.mustNotCall(),
destroy: common.mustCall((id) => {
assert.strictEqual(seenId, id);
})
}).enable();
const immediate = setImmediate(common.mustNotCall());
assert.strictEqual(immediate, seenResource);
clearImmediate(immediate);