From 7864bb9eb8211a6b5dfdaa65456ba05b393a6161 Mon Sep 17 00:00:00 2001 From: Dave Pacheco Date: Tue, 7 Feb 2012 17:21:51 -0800 Subject: [PATCH] build: disable -fomit-frame-pointer on solaris This "optimization" cripples debuggability and has dubious performance value, so we want to disable it at least on SmartOS. --- common.gypi | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/common.gypi b/common.gypi index 582af85369b..6640578c7e7 100644 --- a/common.gypi +++ b/common.gypi @@ -34,8 +34,13 @@ }, }, 'Release': { + 'conditions': [ + [ 'OS!="solaris"', { + 'cflags': [ '-fomit-frame-pointer' ] + }], + ], # 'defines': [ 'NDEBUG' ], - 'cflags': [ '-O3', '-fomit-frame-pointer', '-fdata-sections', '-ffunction-sections' ], + 'cflags': [ '-O3', '-fdata-sections', '-ffunction-sections' ], 'conditions': [ ['target_arch=="x64"', { 'msvs_configuration_platform': 'x64',